This repository has been archived by the owner on Jan 28, 2025. It is now read-only.
Creating All Chuncks in AllGather Collective OOP #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binyang2014
reviewed
Dec 18, 2024
| if self.create_all_chunks: | ||
| for rank in range(self.num_ranks): | ||
| for ch in range(self.chunk_factor): | ||
| output_buffer[rank * self.chunk_factor + ch] = Chunk(rank, ch, -1, rank * self.chunk_factor + ch) |
There was a problem hiding this comment.
The args for Chunk seems incorrect. There are some comments:
- original_rank should always be r I think. For example, for GPU 0, the chunks in output buffer should set original rank to 0
- For last two args in Chunk constructor, set it to -1, -1?
There was a problem hiding this comment.
This make sense, I guess you are right. BTW the same is wrong in the inplace scenario, right? I guess that I did the same mistake there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.