-
Notifications
You must be signed in to change notification settings - Fork 63
Multiple changes from insiders #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
placerda
wants to merge
13
commits into
main
Choose a base branch
from
insiders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placerda patch 1
Update config.json
Removed unused Variables
…rrently available in semantic kernel
Bring your own model update
gbecerra1982
approved these changes
Jan 25, 2025
gbecerra1982
approved these changes
Jan 25, 2025
gbecerra1982
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes across multiple files to enhance Azure integration, improve error handling, and refactor code for better maintainability. The most important changes include adding Azure Monitor tracing, updating the
get_answer
function to accept credentials, and refactoring thecreate_kernel
function to support different deployment scenarios.Azure Integration Enhancements:
orc/code_orchestration.py
: Added imports for Azure Monitor and AI Inference, and enabled Azure Monitor tracing if theAPPLICATION_INSIGHTS_CONNECTION_STRING
environment variable is set. Updatedget_answer
function to acceptchainedTokenCredential
and initialize thekernel
with it. [1] [2] [3]Error Handling Improvements:
orc/code_orchestration.py
: Wrapped the security hub audit invocation in a try-except block to log errors if the audit fails.Function and Variable Updates:
orc/orchestrator.py
: Updated therun
function to pass thecredential
to theget_answer
function.orc/plugins/Conversation/Answer/config.json
: Changed the input variable name fromquestion
toask
.Code Refactoring:
shared/util.py
: Refactoredcreate_kernel
to support different deployment scenarios and added aDummyAsyncContextManager
class for AI Foundry deployments. Updatedget_aoai_config
to includemodel_endpoint
in the configuration. [1] [2] [3] [4]