feat: Add placement status metrics #1077
Conversation
britaniar
force-pushed
the
addEdgeMetrics
branch
from
f0ded74 to
fc22495
Compare
britaniar
force-pushed
the
addEdgeMetrics
branch
4 times, most recently
from
c25f067 to
42093bd
Compare
| @@ -222,12 +223,12 @@ func (r *Reconciler) handleUpdate(ctx context.Context, crp *fleetv1beta1.Cluster | |||
| klog.V(2).InfoS("Placement has finished the rollout process and reached the desired status", "clusterResourcePlacement", crpKObj, "generation", crp.Generation) | |||
| r.Recorder.Event(crp, corev1.EventTypeNormal, "PlacementRolloutCompleted", "Placement has finished the rollout process and reached the desired status") | |||
| } | |||
| metrics.FleetPlacementStatus.WithLabelValues(crp.Name).Set(1) | |||
| metrics.FleetPlacementComplete.WithLabelValues(crp.Name).SetToCurrentTime() | |||
There was a problem hiding this comment.
i remember i never see people emit the cpu metrics with the timestamp. Could you please investigate how people create the gauge metrics?
There was a problem hiding this comment.
I talked to Arvind about this too as my reaction was exactly the same "I never see people emit metrics with the timestamp" but it turned out there is actually a reason for this
There was a problem hiding this comment.
the timestamp is there to help to setup alerts for "snapshot" instead of including all the history
| return condition.IsConditionStatusTrue(crp.GetCondition(string(fleetv1beta1.ClusterResourcePlacementScheduledConditionType)), crp.Generation) | ||
| cond := crp.GetCondition(string(fleetv1beta1.ClusterResourcePlacementScheduledConditionType)) | ||
| if cond != nil { | ||
| emitPlacementStatusMetric(cond, crp) |
There was a problem hiding this comment.
there are multiple ways to create the status metrics,
for example,
the label is, crp name, generation, value is status for that generation.
could you please investigate how others emit metrics?
There was a problem hiding this comment.
I wonder if including the crp name can result in cardinality being too large?
britaniar
force-pushed
the
addEdgeMetrics
branch
2 times, most recently
from
e8afb26 to
d7683e2
Compare
britaniar
force-pushed
the
addEdgeMetrics
branch
from
d7683e2 to
6f85e45
Compare
| cond := crp.GetCondition(string(fleetv1beta1.ClusterResourcePlacementScheduledConditionType)) | ||
| if cond != nil { | ||
| metrics.FleetPlacementStatus.DeletePartialMatch(prometheus.Labels{"name": crp.Name}) | ||
| metrics.FleetPlacementStatus.WithLabelValues(crp.Name, strconv.FormatInt(crp.Generation, 10), cond.Type, string(cond.Status)).SetToCurrentTime() |
There was a problem hiding this comment.
Any thought on setting it as SetToCurrentTime() or Set(float(LastTransitionTime.Unixnano()))
There was a problem hiding this comment.
it seems that SetToCurrentTime is a built-in? If so, I would prefer that
There was a problem hiding this comment.
Okay, I will leave as is then.
Description of your changes
Fixes #
I have: added a metric to emit crp condition status' along with a test.
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer