Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update cro docs #1025

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

zhiying-lin
Copy link
Contributor

Description of your changes

update cro docs, to add placement name, reserved variables, and delete override type

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

RO docs will be in a separate PR

@zhiying-lin zhiying-lin requested a review from Copilot January 23, 2025 11:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

docs/concepts/Override/README.md:71

  • The field JSONPatchOverrides is repeated. Remove the duplicate entry to avoid confusion.
- `JSONPatchOverrides`: a list of JSON path override rules applied to the selected resources following [RFC 6902](https://datatracker.ietf.org/doc/html/rfc6902).

docs/howtos/cluster-resource-override.md Outdated Show resolved Hide resolved
docs/howtos/cluster-resource-override.md Outdated Show resolved Hide resolved
docs/concepts/Override/README.md Show resolved Hide resolved
@ryanzhang-oss ryanzhang-oss merged commit 4884796 into Azure:main Jan 23, 2025
13 checks passed
@zhiying-lin zhiying-lin deleted the update-override-doc branch January 24, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants