feat: drift detection and takeover implementation (1/ contd) #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+167
to
+169
| wrappedErr := fmt.Errorf("unexpected apply strategy %s is found", applyStrategy.Type) | ||
| _ = controller.NewUnexpectedBehaviorError(wrappedErr) | ||
| return nil, wrappedErr |
There was a problem hiding this comment.
I wonder why don't we return the unexpectedError here but return APIServer errors in other places?
There was a problem hiding this comment.
is that UnExpected erorr are "unExpected" so we don't want to record?
There was a problem hiding this comment.
Hi Ryan! It's still logged; the thing about this one is that the returned error will be formatted into a condition message which the user would be able to see, and the unexpected behavior cannot be handled by the controller part might read a bit weird; do we still want to expose them?
There was a problem hiding this comment.
I will make the changes if that is OK with you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR addresses the leftover comments on #985.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
N/A