Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Eviction & Placement Disruption budget #1007

Merged
merged 11 commits into from
Jan 24, 2025
Merged

docs: Eviction & Placement Disruption budget #1007

merged 11 commits into from
Jan 24, 2025

Conversation

Arvindthiru
Copy link
Contributor

@Arvindthiru Arvindthiru commented Jan 6, 2025 •
edited
Loading

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@Arvindthiru Arvindthiru force-pushed the evictionDocs branch 2 times, most recently from 6d14cf4 to 45cf143 Compare January 10, 2025 20:41
@Arvindthiru Arvindthiru marked this pull request as ready for review January 20, 2025 06:48
michaelawyu
michaelawyu reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, PTAL 🙏

michaelawyu
michaelawyu reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nit comments, PTAL.

docs/howtos/eviction-placement-disruption-budget.md Show resolved Hide resolved
docs/howtos/eviction-placement-disruption-budget.md Outdated Show resolved Hide resolved
docs/concepts/EvictionAndDisruptionBudget/README.md Outdated Show resolved Hide resolved
docs/concepts/EvictionAndDisruptionBudget/README.md Outdated Show resolved Hide resolved
docs/concepts/EvictionAndDisruptionBudget/README.md Outdated Show resolved Hide resolved
docs/concepts/EvictionAndDisruptionBudget/README.md Outdated Show resolved Hide resolved
docs/concepts/EvictionAndDisruptionBudget/README.md Outdated Show resolved Hide resolved
docs/concepts/EvictionAndDisruptionBudget/README.md Outdated Show resolved Hide resolved
examples/eviction/clusterpdb.yaml Outdated Show resolved Hide resolved
examples/eviction/eviction.yaml Outdated Show resolved Hide resolved
michaelawyu
michaelawyu approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arvindthiru Arvindthiru merged commit 20de7b7 into Azure:main Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelawyu michaelawyu michaelawyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arvindthiru @michaelawyu