address comments

Azure · Jan 23, 2025 · 65efd11 · 65efd11
1 parent c628e63
commit 65efd11
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/docs/concepts/EvictionAndDisruptionBudget/README.md b/docs/concepts/EvictionAndDisruptionBudget/README.md
@@ -58,8 +58,12 @@ for both `MaxUnavailable` and `MinAvailable`, the user can specify the number of
 
 When specifying a disruption budget for a particular `ClusterResourcePlacement`, the user needs to consider the following cases:
 
-- For `PickFixed` CRP, whether a `ClusterResourcePlacementDisruptionBudget` is specified or not, if an eviction object is created, the user will receive an invalid eviction error message in the eviction status.
-- For `PickAll` CRP, if the `ClusterResourcePlacementDisruptionBudget` is specified for the following cases, the user will receive a misconfigured placement disruption budget error message in the eviction status because total number of clusters selected is non-deterministic
-  - If the `MaxUnavailable` field is set either as integer or as a percentage.
-  - If the `MinAvailable` field is set as a percentage.
-- For `PickN` CRP, if a `ClusterResourcePlacementDisruptionBudget` is specified, the user can either set `MaxUnavailable` or `MinAvailable` field as an integer or percentage since the fields are mutually exclusive.
+| CRP type     | `MinAvailable` DB with an integer | `MinAvailable` DB with a percentage | `MaxUnavailable` DB with an integer | `MaxUnavailable` DB with a percentage |
+|--------------|-----------------------------------|-------------------------------------|-------------------------------------|---------------------------------------|
+| `PickFixed`  | ❌                                 | ❌                                   | ❌                                   | ❌                                |
+| `PickAll`    | ✅                                 | ❌                                   | ❌                                   | ❌                                |
+| `PickN`      | ✅                                 | ✅                                   | ✅                                   | ✅                                |
+
+> **Note:** We don't allow eviction for `PickFixed` CRP and hence specifying a `ClusterResourcePlacementDisruptionBudget` for `PickFixed` CRP does nothing. 
+> And for `PickAll` CRP, the user can only specify `MinAvailable` because total number of clusters selected by a `PickAll` CRP is non-deterministic.
+> If the user creates an invalid `ClusterResourcePlacementDisruptionBudget` object, when an eviction is created, the eviction won't be successfully executed.
diff --git a/docs/howtos/eviction-placement-disruption-budget.md b/docs/howtos/eviction-placement-disruption-budget.md
@@ -132,7 +132,7 @@ spec:
   minAvailable: 1
 ```
 
-> **Note:** An eviction object is only reconciled once, after which it reaches a terminal state, if the user desires to use the same eviction object again they need to delete the existing eviction object and re-create the object for the eviction to occur.
+> **Note:** An eviction object is only reconciled once, after which it reaches a terminal state, if the user desires to create/apply the same eviction object again they need to delete the existing eviction object and re-create the object for the eviction to occur again.
 
 Now we will create a `ClusterResourcePlacementEviction` object to evict resources from the member cluster: