Conversation
added 2 commits
October 28, 2025 12:13
cgillum
reviewed
Oct 28, 2025
cgillum
approved these changes
Oct 30, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
LGTM! I assume the plan is that the out-of-process SDKs will need to similarly add these events to the completion tags?
sophiatev
deleted the
stevosyan/add-warning-for-failed-continue-as-new
branch
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warning when the
TaskOrchestrationContextdetects that continue-as-new has been called on a failed orchestration (in which case the continue-as-new is ignored and the orchestration is completed in a "failed" state). It does this by introducing a new genericOrchestrationCompletedWithWarninglog and a newTagsfield to theOrchestrationCompleteOrchestratorActionwhich can be leveraged generically in the future for other such cases.Solves #1261