Skip to content

Conversation

RubenCerna2079
Copy link
Contributor

@RubenCerna2079 RubenCerna2079 commented Jul 17, 2025

Why make this change?

This change closes issue #2771.

What is this change?

This change extends the functionality of the add-telemetry CLI command by introducing support for Azure Log Analytics properties. With this enhancement, users can now add telemetry settings to their configuration file without the need to directly edit it.

How was this tested?

  • Integration Tests
  • Unit Tests

Sample Request(s)

CLI Updates
Add support to dab add-telemetry:

dab add-telemetry --azure-log-analytics-enabled
dab add-telemetry --azure-log-analytics-auth-workspace-id
dab add-telemetry --azure-log-analytics-auth-dcr-immutable-id
dab add-telemetry --azure-log-analytics-auth-dce-endpoint
dab add-telemetry --azure-log-analytics-log-type
dab add-telemetry --azure-log-analytics-flush-interval-seconds

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, but needs to fix description, title to mention this is adding add-telemetry options to the CLI instead of saying "Add CLI Azure Log Analytics".

@RubenCerna2079 RubenCerna2079 changed the title Add CLI Azure Log Analytics Adding 'add-telemetry' Options to CLI for Azure Log Analytics Jul 17, 2025
@RubenCerna2079 RubenCerna2079 force-pushed the dev/rubencerna/add-cli-log-analytics branch from 5360ea7 to 247147a Compare July 21, 2025 18:24
@RubenCerna2079 RubenCerna2079 force-pushed the dev/rubencerna/add-cli-log-analytics branch from 247147a to aa349c8 Compare July 21, 2025 20:52
@RubenCerna2079
Copy link
Contributor Author

/azp run

@RubenCerna2079
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@RubenCerna2079
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@JerryNixon
Copy link
Contributor

JerryNixon commented Jul 22, 2025

CLI decision

We will:

  1. NOT enhance add-telemetry in any way
  2. NOT remove add-telemetry for backwards compatibility
  3. NOT include add-telemetry in the online docs (I did this already)
  4. REMOVE add-telemetry in the console --help docs (Ruben Cerna will)
  5. Console output with add-telemetry. (Ruben Cerna will) Deprecation message: "The add-telemetry command is deprecated, use dab configure for complete support".

@Aniruddh25
Copy link
Collaborator

Given the decision to deprecate add-telemetry, Im closing this PR.

@Aniruddh25 Aniruddh25 closed this Jul 24, 2025
@RubenCerna2079 RubenCerna2079 deleted the dev/rubencerna/add-cli-log-analytics branch August 22, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'add-telemetry' CLI options for Azure Log Analytics
4 participants