-
Notifications
You must be signed in to change notification settings - Fork 267
Adding 'add-telemetry' Options to CLI for Azure Log Analytics #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: RubenCerna2079 <[email protected]>
…erProvided flags Co-authored-by: aaronburtle <[email protected]>
…ided flags Co-authored-by: aaronburtle <[email protected]>
Aniruddh25
reviewed
Jul 17, 2025
Aniruddh25
reviewed
Jul 17, 2025
Aniruddh25
reviewed
Jul 17, 2025
Aniruddh25
reviewed
Jul 17, 2025
Aniruddh25
requested changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, but needs to fix description, title to mention this is adding add-telemetry options to the CLI instead of saying "Add CLI Azure Log Analytics".
JerryNixon
requested changes
Jul 18, 2025
5360ea7
to
247147a
Compare
247147a
to
aa349c8
Compare
/azp run |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
CLI decisionWe will:
|
Given the decision to deprecate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
This change closes issue #2771.
What is this change?
This change extends the functionality of the
add-telemetry
CLI command by introducing support for Azure Log Analytics properties. With this enhancement, users can now add telemetry settings to their configuration file without the need to directly edit it.How was this tested?
Sample Request(s)
CLI Updates
Add support to dab add-telemetry:
dab add-telemetry --azure-log-analytics-enabled
dab add-telemetry --azure-log-analytics-auth-workspace-id
dab add-telemetry --azure-log-analytics-auth-dcr-immutable-id
dab add-telemetry --azure-log-analytics-auth-dce-endpoint
dab add-telemetry --azure-log-analytics-log-type
dab add-telemetry --azure-log-analytics-flush-interval-seconds