-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot Reload for Loggers #2634
base: main
Are you sure you want to change the base?
Hot Reload for Loggers #2634
Conversation
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
5bf2a26
to
f628808
Compare
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
0a4a0c4
to
24cb9ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes to "compare" configs in Production mode.
The base branch was changed.
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question about setting the log level during a hot-reload in production scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge. Thanks for addressing the delicate issue around hot reloading only the log-level in Production mode.
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
Why make this change?
Closes issues #2580 and #2582
What is this change?
Adds hot reload feature for loggers which makes it possible for the user to change the log level filters without restarting the application. This is done by ensuring that the logger factories are updated when there is a hot reload event.
This feature is also available in production mode, it is the only hot reloadable property in production mode.
How was this tested?
Test added:
Sample Request(s)
Before hot reload:


After hot reload:

