-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Custom log-level for Classes via log-level Filters #2620
Conversation
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
0b89823
to
24c3d2c
Compare
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, suggest to change PR title to explain a bit more about what this change is enabling
e.g. "Enable custom log level for classes via log-level
filters"
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments so far. Looks good to merge, just have a couple of pointers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I am around half way through, will try to finish today.
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why make this change?
This change solves tasks, #2584, #2585, #2586, #2587, #2588, #2569.
All of them are part of the bigger task of #2563 which adds filters for logging.
What is this change?
This change allows the users to add more specific logging filters to their config file, this means that log-levels meant for a specific class will take priority over the default log-level.
In the following example, even if the default is in
debug
, the logging forIQueryExecutor
will be ininformation
.Specific Changes:
default
TelemetryOptions
class and it uses the saved log-levels to dictate if a specific logger uses a different log-level from the default. This change gets rid of theloggerFactory
and changes it to a dictionary.How was this tested?
Following tests were added:
Sample Request(s)