-
Notifications
You must be signed in to change notification settings - Fork 473
feat: avm/res/container-service/managed-cluster
Updates container service to support automatic clusters
#2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
.github/actions/templates/avm-validateModuleDeployment/action.yml
Outdated
Show resolved
Hide resolved
Hey, @AlexanderSehr - Updated according to your comments. Please re-review it, thanks! |
This looks good to me but I'm concerned about the failing pipeline. @JPEasier are you aware of the pipeline failure error? |
It seems that because of the resource quota under the subscription, after I changed the region, the pipeline can pass normally. |
@AlexanderSehr, @ilhaan, @JPEasier - Since the pipeline status badge has passed and you have reviewed it, I removed the changes that were not related to this PR (login with fed credential). If you don't have any other questions, could you help me merge this PR, thanks! |
Looks good to me, but I'll leave it to the module owners to give their blessing and approve the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zedy-wj Approved. Thank you!
Description
Related to PR: Azure/azure-dev#4069
Adds new automatic setting for container service managed cluster.
Set
azure/login@v2
to use federated credential. (Due to some security policies, we are currently unable to use client secret for azure login. After completing all changes to this PR, we will restore the login method. This is currently only for testing the github pipeline.)The failed test in the Pipeline Status Badge has nothing to do with this PR. The specific information can be viewed at: https://github.com/zedy-wj/bicep-registry-modules/actions/runs/10053355723/job/27786049197#step:4:649.
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.@jongio for notification.