Skip to content

feat: avm/res/container-service/managed-cluster Updates container service to support automatic clusters #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

zedy-wj
Copy link
Member

@zedy-wj zedy-wj commented Jul 23, 2024

Description

Related to PR: Azure/azure-dev#4069

Adds new automatic setting for container service managed cluster.

Set azure/login@v2 to use federated credential. (Due to some security policies, we are currently unable to use client secret for azure login. After completing all changes to this PR, we will restore the login method. This is currently only for testing the github pipeline.)

The failed test in the Pipeline Status Badge has nothing to do with this PR. The specific information can be viewed at: https://github.com/zedy-wj/bicep-registry-modules/actions/runs/10053355723/job/27786049197#step:4:649.

Pipeline Reference

Pipeline
avm.res.container-service.managed-cluster

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio for notification.

@zedy-wj zedy-wj requested review from a team as code owners July 23, 2024 06:07
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 23, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jul 23, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@zedy-wj
Copy link
Member Author

zedy-wj commented Jul 24, 2024

Hey, @AlexanderSehr - Updated according to your comments. Please re-review it, thanks!

@AlexanderSehr
Copy link
Collaborator

Hey @ilhaan & @JPEasier, I took the liberty to add some comments that @zedy-wj already addressed.
As you're the owners, please take a look when you get the chance and comment/approve as you see fit 💪

@ilhaan
Copy link
Member

ilhaan commented Jul 24, 2024

This looks good to me but I'm concerned about the failing pipeline. @JPEasier are you aware of the pipeline failure error?

@zedy-wj
Copy link
Member Author

zedy-wj commented Jul 25, 2024

ently unable to use client secret for azure login. After completing all changes to this PR, we will restore the login method. This is currently only for testing the github

It seems that because of the resource quota under the subscription, after I changed the region, the pipeline can pass normally.

@zedy-wj
Copy link
Member Author

zedy-wj commented Jul 25, 2024

@AlexanderSehr, @ilhaan, @JPEasier - Since the pipeline status badge has passed and you have reviewed it, I removed the changes that were not related to this PR (login with fed credential). If you don't have any other questions, could you help me merge this PR, thanks!

@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jul 25, 2024
@AlexanderSehr
Copy link
Collaborator

Looks good to me, but I'll leave it to the module owners to give their blessing and approve the PR :)

Copy link
Member

@ilhaan ilhaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zedy-wj Approved. Thank you!

@ilhaan ilhaan merged commit 8eb3b70 into Azure:main Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants