Skip to content

Fix LRO poller to treat HTTP 404/406 as transient during transaction-status polling #46310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+394 −2
Open

Fix LRO poller to treat HTTP 404/406 as transient during transaction-status polling #46310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e05b180
Fix LRO poller to treat HTTP 404 and 406 as transient during transact…
Copilot Apr 13, 2026
304414a
Restore original 404 retry logic (with counter) and add separate 406 …
Copilot Apr 14, 2026
2cd34a0
Merge branch 'main' into copilot/fix-lro-poller-transaction-status
PallabPaul Apr 14, 2026
00bad60
Merge branch 'main' into copilot/fix-lro-poller-transaction-status
PallabPaul Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...onfidentialledger/azure-confidentialledger/azure/confidentialledger/_operations/_patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import time
from typing import Any, Callable, IO, List, Optional, Union, cast

from azure.core.exceptions import ResourceNotFoundError
from azure.core.exceptions import HttpResponseError, ResourceNotFoundError
from azure.core.polling import PollingMethod, LROPoller, NoPolling

from azure.confidentialledger._operations._operations import (
Expand Down Expand Up @@ -112,6 +112,14 @@ def run(self) -> None:

if not_retryable or self._not_found_count >= 3:
raise
Comment on lines 113 to 114
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code enforces the 404 retry limit using a monotonic _not_found_count, but the tests/docstrings describe the behavior as '3 consecutive 404s'. As implemented, non-consecutive 404s (e.g., 404 → 406 → 404 → 406 → 404) will still eventually hit the limit and fail. Please either (a) reset _not_found_count after any successful poll / any non-404 attempt (including the 406 transient path) to make it truly 'consecutive', or (b) update the docstrings/tests to explicitly state the limit is on the total number of 404s during a polling run.

Copilot uses AI. Check for mistakes.
except HttpResponseError as http_exception:
# 406: node knows the transaction but it hasn't committed yet.
# This is transient during transaction-status polling — treat as
# pending so the poller retries.
if http_exception.status_code == 406 and self._retry_not_found:
pass # stay in polling loop
else:
raise
if not self.finished():
time.sleep(self._polling_interval_s)
except Exception:
Expand Down
10 changes: 9 additions & 1 deletion ...dentialledger/azure-confidentialledger/azure/confidentialledger/aio/_operations/_patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import asyncio # pylint: disable=do-not-import-asyncio
from typing import Any, Callable, IO, Coroutine, List, Optional, Union, cast

from azure.core.exceptions import ResourceNotFoundError
from azure.core.exceptions import HttpResponseError, ResourceNotFoundError
from azure.core.polling import AsyncLROPoller, AsyncNoPolling, AsyncPollingMethod

from azure.confidentialledger.aio._operations._operations import (
Expand Down Expand Up @@ -66,6 +66,14 @@ async def run(self) -> None:

if not_retryable or self._not_found_count >= 3:
raise
except HttpResponseError as http_exception:
# 406: node knows the transaction but it hasn't committed yet.
# This is transient during transaction-status polling — treat as
# pending so the poller retries.
if http_exception.status_code == 406 and self._retry_not_found:
pass # stay in polling loop
else:
raise
if not self.finished():
await asyncio.sleep(self._polling_interval_s)
except Exception:
Expand Down
Loading
Loading