App Config SDK/Provider Pylint Updates

sdk/appconfiguration/azure-appconfiguration-provider/samples/aad_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
 import os
 from sample_utilities import get_authority, get_credential, get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 endpoint = os.environ.get("APPCONFIGURATION_ENDPOINT_STRING")
 authority = get_authority(endpoint)

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_aad_sample.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
 import asyncio
+from sample_utilities import get_authority, get_credential, get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-import os
-from sample_utilities import get_authority, get_credential, get_client_modifications
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_connection_string_sample.py

@@ -3,11 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+import os
 import asyncio
+from sample_utilities import get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-from sample_utilities import get_client_modifications
-import os
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_key_vault_reference_provided_clients_sample.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
 import asyncio
+from sample_utilities import get_authority, get_credential, get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-import os
-from sample_utilities import get_authority, get_credential, get_client_modifications
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_key_vault_reference_sample.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
 import asyncio
+from sample_utilities import get_authority, get_credential, get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-import os
-from sample_utilities import get_authority, get_credential, get_client_modifications
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_snapshot_sample.py

@@ -3,19 +3,18 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
+import uuid
 import asyncio
-from azure.appconfiguration.provider.aio import load
-from azure.appconfiguration.provider import SettingSelector
 from azure.appconfiguration.aio import AzureAppConfigurationClient  # type:ignore
 from azure.appconfiguration import (  # type:ignore
     ConfigurationSettingsFilter,
     ConfigurationSetting,
     FeatureFlagConfigurationSetting,
 )
 from azure.identity.aio import DefaultAzureCredential
-import os
-import uuid
+from azure.appconfiguration.provider.aio import load
+from azure.appconfiguration.provider import SettingSelector
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/connection_string_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
-from sample_utilities import get_client_modifications
 import os
+from sample_utilities import get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 kwargs = get_client_modifications()
 connection_string = os.environ["APPCONFIGURATION_CONNECTION_STRING"]

sdk/appconfiguration/azure-appconfiguration-provider/samples/key_vault_reference_customized_clients_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
 import os
 from sample_utilities import get_authority, get_credential, get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 endpoint = os.environ["APPCONFIGURATION_ENDPOINT_STRING"]
 key_vault_uri = os.environ["KEYVAULT_URL"]

sdk/appconfiguration/azure-appconfiguration-provider/samples/key_vault_reference_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
 import os
 from sample_utilities import get_authority, get_audience, get_credential, get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 endpoint = os.environ["APPCONFIGURATION_ENDPOINT_STRING"]
 authority = get_authority(endpoint)

sdk/appconfiguration/azure-appconfiguration-provider/samples/refresh_sample.py

@@ -3,14 +3,14 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-from azure.appconfiguration.provider import load, WatchKey
+import os
+import time
+from sample_utilities import get_client_modifications
 from azure.appconfiguration import (  # type:ignore
     AzureAppConfigurationClient,
     ConfigurationSetting,
 )
-from sample_utilities import get_client_modifications
-import os
-import time
+from azure.appconfiguration.provider import load, WatchKey
 
 kwargs = get_client_modifications()
 connection_string = os.environ.get("APPCONFIGURATION_CONNECTION_STRING")
@@ -23,11 +23,12 @@
 client.set_configuration_setting(configuration_setting=configuration_setting)
 
 
-def my_callback_on_fail(error):
+def my_callback_on_fail(_):
     print("Refresh failed!")
 
 
-# Connecting to Azure App Configuration using connection string, and refreshing when the configuration setting message changes
+# Connecting to Azure App Configuration using connection string, and refreshing when the configuration setting message
+# changes
 config = load(
     connection_string=connection_string,
     refresh_on=[WatchKey("message")],

sdk/appconfiguration/azure-appconfiguration-provider/samples/refresh_sample_feature_flags.py

@@ -3,15 +3,15 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-from azure.appconfiguration.provider import load, WatchKey
+import os
+import time
+from sample_utilities import get_client_modifications
 from azure.appconfiguration import (  # type:ignore
     AzureAppConfigurationClient,
     ConfigurationSetting,
     FeatureFlagConfigurationSetting,
 )
-from sample_utilities import get_client_modifications
-import os
-import time
+from azure.appconfiguration.provider import load, WatchKey
 
 kwargs = get_client_modifications()
 connection_string = os.environ.get("APPCONFIGURATION_CONNECTION_STRING")
@@ -26,11 +26,12 @@
 client.set_configuration_setting(configuration_setting=feature_flag_setting)
 
 
-def my_callback_on_fail(error):
+def my_callback_on_fail(_):
     print("Refresh failed!")
 
 
-# Connecting to Azure App Configuration using connection string, and refreshing when the configuration setting message changes
+# Connecting to Azure App Configuration using connection string, and refreshing when the configuration setting message
+# changes
 config = load(
     connection_string=connection_string,
     refresh_on=[WatchKey("message")],

sdk/appconfiguration/azure-appconfiguration-provider/samples/sample_utilities.py

@@ -39,6 +39,7 @@ def get_audience(authority):
         return "https://management.usgovcloudapi.net"
     if authority == "login.azure-test.net":
         return "https://management.azure-test.net"
+    return ""
 
 
 def get_credential(authority, **kwargs):

sdk/appconfiguration/azure-appconfiguration-provider/samples/snapshot_sample.py

@@ -10,7 +10,6 @@
 from azure.appconfiguration import (  # type:ignore
     AzureAppConfigurationClient,
     ConfigurationSettingsFilter,
-    ConfigurationSnapshot,
     ConfigurationSetting,
     FeatureFlagConfigurationSetting,
 )

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/key_vault/test_async_secret_provider.py

@@ -5,12 +5,12 @@
 # --------------------------------------------------------------------------
 import unittest
 from unittest.mock import Mock, patch, AsyncMock
-from azure.appconfiguration import SecretReferenceConfigurationSetting
-from azure.appconfiguration.provider.aio._key_vault._async_secret_provider import SecretProvider
-from azure.keyvault.secrets.aio import SecretClient
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from asynctestcase import AppConfigTestCase
+from azure.appconfiguration import SecretReferenceConfigurationSetting
+from azure.keyvault.secrets.aio import SecretClient
+from azure.appconfiguration.provider.aio._key_vault._async_secret_provider import SecretProvider
 
 TEST_SECRET_ID = "https://myvault.vault.azure.net/secrets/my_secret"
 

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/key_vault/test_async_secret_refresh.py

@@ -8,11 +8,10 @@
 import unittest
 from unittest.mock import Mock, patch
 from devtools_testutils.aio import recorded_by_proxy_async
-from azure.appconfiguration import SecretReferenceConfigurationSetting
-from azure.appconfiguration.provider import SettingSelector, WatchKey
-from devtools_testutils import recorded_by_proxy
 from async_preparers import app_config_aad_decorator_async
 from asynctestcase import AppConfigTestCase
+from azure.appconfiguration import SecretReferenceConfigurationSetting
+from azure.appconfiguration.provider import SettingSelector, WatchKey
 
 
 class TestAsyncSecretRefresh(AppConfigTestCase, unittest.TestCase):

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_async_discovery.py

@@ -3,16 +3,16 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-import pytest
 from unittest.mock import patch, call
+import pytest
+from dns.resolver import NXDOMAIN, YXDOMAIN, LifetimeTimeout, NoNameservers  # cspell:disable-line
 from azure.appconfiguration.provider.aio._async_discovery import (
     _get_known_domain,
     _request_record,
     _find_replicas,
     _find_origin,
     find_auto_failover_endpoints,
 )
-from dns.resolver import NXDOMAIN, YXDOMAIN, LifetimeTimeout, NoNameservers, Answer  # cspell:disable-line
 
 AZCONFIG_IO = ".azconfig.io"  # cspell:disable-line
 APPCONFIG_IO = ".appconfig.io"  # cspell:disable-line

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_async_provider.py

@@ -3,13 +3,13 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-from azure.appconfiguration.provider import SettingSelector, AzureAppConfigurationKeyVaultOptions
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from testcase import has_feature_flag
 from asynctestcase import AppConfigTestCase
 from test_constants import FEATURE_MANAGEMENT_KEY
 from unittest.mock import MagicMock, patch
+from azure.appconfiguration.provider import SettingSelector, AzureAppConfigurationKeyVaultOptions
 from azure.appconfiguration.provider.aio._azureappconfigurationproviderasync import (
     _buildprovider,
 )
@@ -226,8 +226,8 @@ async def test_mapper(setting):
             configuration_mapper=test_mapper,
             trim_prefixes=["refresh_"],
         ) as client:
-            # Because our processing happens after mapping and refresh_message is alphabetically after message the override
-            # value isn't used, as the mapped value is overridden by the first value.
+            # Because our processing happens after mapping and refresh_message is alphabetically after message the
+            # override value isn't used, as the mapped value is overridden by the first value.
             assert client["message"] == "original value"
             assert "refresh_message" not in client
 

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_async_provider_aad.py

@@ -3,12 +3,12 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-from azure.appconfiguration.provider import SettingSelector, AzureAppConfigurationKeyVaultOptions
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from testcase import has_feature_flag
 from asynctestcase import AppConfigTestCase
 from test_constants import FEATURE_MANAGEMENT_KEY
+from azure.appconfiguration.provider import SettingSelector, AzureAppConfigurationKeyVaultOptions
 
 
 class TestAppConfigurationProvider(AppConfigTestCase):

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_async_provider_feature_management.py

@@ -3,14 +3,14 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-from azure.appconfiguration.provider import SettingSelector
-from azure.appconfiguration.provider.aio import load
-from azure.appconfiguration.aio import AzureAppConfigurationClient
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from testcase import has_feature_flag
 from asynctestcase import AppConfigTestCase, setup_configs
 from test_constants import FEATURE_MANAGEMENT_KEY
+from azure.appconfiguration.provider import SettingSelector
+from azure.appconfiguration.provider.aio import load
+from azure.appconfiguration.aio import AzureAppConfigurationClient
 
 
 class TestAppConfigurationProviderFeatureManagement(AppConfigTestCase):

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_async_provider_refresh.py

@@ -5,17 +5,16 @@
 # --------------------------------------------------------------------------
 import time
 import unittest
-import pytest
 import sys
-
-from azure.appconfiguration import ConfigurationSetting
-from azure.appconfiguration.provider import WatchKey
+from unittest.mock import Mock
+import pytest
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from testcase import has_feature_flag
 from asynctestcase import AppConfigTestCase
 from test_constants import FEATURE_MANAGEMENT_KEY
-from unittest.mock import Mock
+from azure.appconfiguration import ConfigurationSetting
+from azure.appconfiguration.provider import WatchKey
 
 try:
     # Python 3.7 does not support AsyncMock

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_async_snapshots.py

@@ -3,8 +3,6 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-
-import pytest
 import time
 from azure.appconfiguration.provider._models import SettingSelector
 from azure.appconfiguration.provider._constants import NULL_CHAR, FEATURE_MANAGEMENT_KEY, FEATURE_FLAG_KEY

sdk/appconfiguration/azure-appconfiguration-provider/tests/aio/test_configuration_async_client_manager.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-import pytest
-
 import time
 from unittest.mock import patch, call
+import pytest
 from azure.appconfiguration.provider.aio._async_client_manager import AsyncConfigurationClientManager
 
 
@@ -26,7 +25,8 @@ class TestAsyncConfigurationClientManager:
     @pytest.mark.asyncio
     @patch("azure.appconfiguration.provider.aio._async_client_manager.find_auto_failover_endpoints")
     @patch(
-        "azure.appconfiguration.provider.aio._async_client_manager._AsyncConfigurationClientWrapper.from_connection_string"
+        "azure.appconfiguration.provider.aio._async_client_manager"
+        "._AsyncConfigurationClientWrapper.from_connection_string"
     )
     async def test_create_client_manager_connection_string(self, mock_client, mock_update_failover_endpoints):
         endpoint = "https://fake.endpoint"
@@ -56,7 +56,8 @@ async def test_create_client_manager_connection_string(self, mock_client, mock_u
     @pytest.mark.asyncio
     @patch("azure.appconfiguration.provider.aio._async_client_manager.find_auto_failover_endpoints")
     @patch(
-        "azure.appconfiguration.provider.aio._async_client_manager._AsyncConfigurationClientWrapper.from_connection_string"
+        "azure.appconfiguration.provider.aio._async_client_manager"
+        "._AsyncConfigurationClientWrapper.from_connection_string"
     )
     async def test_failover_create_client_manager_connection_string(self, mock_client, mock_update_failover_endpoints):
         endpoint = "https://fake.endpoint"
@@ -221,7 +222,8 @@ async def test_refresh_clients_credential(self, mock_client, mock_update_failove
     @pytest.mark.asyncio
     @patch("azure.appconfiguration.provider.aio._async_client_manager.find_auto_failover_endpoints")
     @patch(
-        "azure.appconfiguration.provider.aio._async_client_manager._AsyncConfigurationClientWrapper.from_connection_string"
+        "azure.appconfiguration.provider.aio._async_client_manager"
+        "._AsyncConfigurationClientWrapper.from_connection_string"
     )
     async def test_refresh_clients_connection_string(self, mock_client, mock_update_failover_endpoints):
         endpoint = "https://fake.endpoint"