-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[CQA SDK] Update test and record #45036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates tests and test recordings for the Cognitive Language Question Answering (CQA) SDK, affecting both the runtime (question answering) and authoring packages.
Changes:
- Removed metadata filter test coverage from question answering runtime tests (both sync and async)
- Replaced source-based tests with QnA-based tests in the authoring package
- Updated test recording asset tags to reflect new test recordings
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase.py | Removed test_query_knowledgebase_filter test that validated metadata filtering functionality |
| sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase_async.py | Removed async version of test_query_knowledgebase_filter test |
| sdk/cognitivelanguage/azure-ai-language-questionanswering/assets.json | Updated test recording asset tag |
| sdk/cognitivelanguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources.py | Renamed test_add_source to test_add_chitchat and changed from testing URL source addition to QnA pair addition |
| sdk/cognitivelanguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources_async.py | Async version of the same test rename and functionality change |
| sdk/cognitivelanguage/azure-ai-language-questionanswering-authoring/assets.json | Updated test recording asset tag |
...anguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources.py
Show resolved
Hide resolved
sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase.py
Show resolved
Hide resolved
...ognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase_async.py
Show resolved
Hide resolved
...e/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources_async.py
Show resolved
Hide resolved
...anguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources.py
Show resolved
Hide resolved
...e/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources_async.py
Show resolved
Hide resolved
|
/azp run python - cognitivelanguage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines