[Storage] [Named Keywords] File Share Package

[weirongw23-msft]

No description provided.

[Copilot]

Pull Request Overview

This pull request merges the File Share Named Keywords branch into main, introducing comprehensive type stubs (.pyi files) for the Azure Storage File Share SDK's async client components and updating the synchronous lease client implementation. The changes enhance type safety and developer experience through improved type annotations and code quality improvements.

Key changes include:

• Addition of complete type stub files for async client classes
• Type safety improvements in the lease client implementation
• Enhanced code formatting and consistency across the codebase

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
aio/_share_service_client_async.pyi	New type stub for async share service client with comprehensive method signatures
aio/_share_client_async.pyi	New type stub for async share client with all share management operations
aio/_lease_async.pyi	New type stub for async lease client operations
aio/_lease_async.py	Updated implementation with improved formatting and type safety
aio/_file_client_async.pyi	New type stub for async file client with file operations
aio/_directory_client_async.pyi	New type stub for async directory client with directory operations
_share_service_client.pyi	New type stub for sync share service client
_share_client.pyi	New type stub for sync share client
_lease.pyi	New type stub for sync lease client
_lease.py	Updated implementation with type safety improvements
_file_client.pyi	New type stub for sync file client
_directory_client.pyi	New type stub for sync directory client

Comments suppressed due to low confidence (2)

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_file_client.pyi:276

• Parameter naming inconsistency: sync version uses 'if_modified_since' while async version uses 'source_if_modified_since'. This could cause confusion for developers switching between sync and async versions.

        if_modified_since: Optional[datetime] = None,

[github-actions]

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-storage-file-share

[vincenttran-msft]

Same comments about consistency between lease sync and async.

Also need to correct the keywords for rename_file it seems?

[vincenttran-msft]

But let Jacob take the last pass