Updating client to add private API needed for evaluation #40484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singankit
requested review from
luigiw,
needuv,
paulshealy1,
dargilco and
jhakulin
as code owners
dargilco
reviewed
Apr 11, 2025
| print("Create dataset for evaluation") | ||
| dataset: DatasetVersion = project_client.datasets.upload_file_and_create( | ||
| name=dataset_name, | ||
| file="sample_folder/sample_eval.jsonl", |
There was a problem hiding this comment.
Did you plan on checking in the .jsonl file?
dargilco
reviewed
Apr 11, 2025
|
|
||
| print("Submitting Evaluation") | ||
| # Create evaluation | ||
| evaluation_response: Evaluation = project_client.evaluations.create( |
There was a problem hiding this comment.
Is there a need for both the comment and print lines (lines 75 & 76)?
dargilco
reviewed
Apr 11, 2025
| ) as project_client: | ||
|
|
||
| print("Create evaluation") | ||
| print("Create dataset for evaluation") |
dargilco
approved these changes
Apr 11, 2025
|
Per our IM chat, please make sure this PR build is fully green before merging to the feature branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines