Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a typo in the CHANGELOG.md #39386

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fixed a typo in the CHANGELOG.md #39386

merged 1 commit into from
Mar 26, 2025

Conversation

rohanthacker
Copy link
Contributor

Description

The document mentions json-object, however the code shows that json_object is the correct value for the discriminator

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@rohanthacker
Fixed a typo in the CHANGELOG.md
ed45dd8 
The document mentions `json-object`, however the code shows that `json_object` is the  correct value for the discriminator
@github-actions GitHub Actions
Copy link

Thank you for your contribution @rohanthacker! We will review the pull request and get back to you soon.

@github-actions github-actions bot added AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 24, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kristapratico
Copy link
Member

@trangevi can you take a look at this PR? Thanks!

@kashifkhan kashifkhan merged commit e989390 into Azure:main Mar 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dargilco dargilco dargilco approved these changes

@trangevi trangevi Awaiting requested review from trangevi trangevi is a code owner

@jhakulin jhakulin Awaiting requested review from jhakulin jhakulin is a code owner

Assignees
No one assigned
Labels
AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohanthacker @azure-sdk @kristapratico @dargilco @kashifkhan