Update _patch.py #39341
Closed
Update _patch.py #39341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the line splitting logic in the code does not handle non-ASCII characters properly. Specifically, the following line:
line_list: List[str] = re.split(r"(?<=\n)", element.decode("utf-8"))
This line attempts to decode the element byte string using UTF-8 encoding. If the element contains non-ASCII characters that cannot be decoded, it will raise a UnicodeDecodeError.
To address this issue, we should add an error handling mechanism to the decode method. There are several options available:
errors="replace": Replace undecodable characters with a replacement character (usually �).
errors="ignore": Ignore undecodable characters.
errors="backslashreplace": Replace undecodable characters with \x escape sequences.
errors="surrogateescape": Save undecodable characters as surrogate characters for later recovery.
For this pull request, I propose using errors="replace" or errors="ignore".
952446418
requested review from
dargilco,
trangevi and
jhakulin
as code owners
github-actions
bot
added
AI Model Inference
|
Thank you for your contribution @952446418! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
trangevi
requested changes
Jan 30, 2025
| @@ -338,7 +338,7 @@ def _deserialize_and_add_to_queue(self, element: bytes) -> bool: | |||
|
|
|||
| # Convert `bytes` to string and split the string by newline, while keeping the new line char. | |||
| # the last may be a partial "line" that does not contain a newline char at the end. | |||
| line_list: List[str] = re.split(r"(?<=\n)", element.decode("utf-8")) | |||
| line_list: List[str] = re.split(r"(?<=\n)", element.decode("utf-8", errors="replace")) # or errors="ignore" | |||
There was a problem hiding this comment.
@952446418 can you please let me know of a test where the current handling is failing for you, and which package version you're using? This may have been fixed in a recent change in a different way, as I am unable to force an error, so I would like to validate that first before merging this change.
|
Closing this PR, as latest release of the azure-ai-inference SDK includes a fix for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the line splitting logic in the code does not handle non-ASCII characters properly. Specifically, the following line: line_list: List[str] = re.split(r"(?<=\n)", element.decode("utf-8")) This line attempts to decode the element byte string using UTF-8 encoding. If the element contains non-ASCII characters that cannot be decoded, it will raise a UnicodeDecodeError.
To address this issue, we should add an error handling mechanism to the decode method. There are several options available:
errors="replace": Replace undecodable characters with a replacement character (usually �). errors="ignore": Ignore undecodable characters.
errors="backslashreplace": Replace undecodable characters with \x escape sequences. errors="surrogateescape": Save undecodable characters as surrogate characters for later recovery. For this pull request, I propose using errors="replace" or errors="ignore".