Skip to content

Conversation

@ArcturusZhang
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.Compute

@ArcturusZhang ArcturusZhang marked this pull request as ready for review November 14, 2025 03:59
Copilot AI review requested due to automatic review settings November 14, 2025 03:59
Copilot finished reviewing on behalf of ArcturusZhang November 14, 2025 04:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure.ResourceManager.Compute SDK to change how Community Gallery and Shared Gallery resources are exposed. The main purpose is to convert these resources from ARM resources to data models, while maintaining backward compatibility through customization files.

Key Changes:

  • Changed Community Gallery and Shared Gallery types from ARM resources to data models
  • Removed 404 response handling from REST operations for these gallery types
  • Added backward compatibility through EditorBrowsable(Never) attributes on deprecated APIs
  • Added new extension methods for accessing gallery data directly on SubscriptionResource

Reviewed Changes

Copilot reviewed 30 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/autorest.md Updated configuration to rename gallery types to *Data suffix and skip certain operations
src/Generated/RestOperations/*RestOperations.cs Removed 404 null return handling from gallery REST operations
src/Generated/Models/*Data.cs Updated XML documentation to single-line format, removed Id properties
src/Generated/Models/*Data.Serialization.cs Added new serialization implementation files for gallery data models
src/Generated/Models/AzureResourceManagerComputeContext.cs Removed resource type registrations, kept data type registrations
src/Generated/Extensions/MockableComputeSubscriptionResource.cs Replaced resource-based methods with new data-based extension methods
src/Generated/Extensions/MockableComputeArmClient.cs Removed resource getter methods
src/Generated/Extensions/ComputeExtensions.cs Removed resource-based extension methods
src/Customize/* Added backward compatibility through hidden resource types and custom implementations
api/Azure.ResourceManager.Compute.netstandard2.0.cs Updated public API surface with EditorBrowsable attributes
CHANGELOG.md Documented breaking changes for gallery resources
tests/Generated/Samples/Sample_SubscriptionResourceExtensions.cs Added new test samples for gallery data methods

@ArcturusZhang ArcturusZhang merged commit f9aaf39 into Azure:main Nov 14, 2025
17 checks passed
@ArcturusZhang ArcturusZhang deleted the remove-some-resources branch November 14, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants