Fix identity snippet #53857
Closed
Fix identity snippet #53857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jsquire |
Copilot finished reviewing on behalf of
live1206
November 13, 2025 08:40
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compilation errors caused by deprecated ManagedIdentityCredential constructor usage. The changes update code samples to use the new recommended constructor that accepts ManagedIdentityId.SystemAssigned parameter instead of the obsolete parameterless constructor.
Key changes:
- Updated
ManagedIdentityCredentialinstantiation to use the new API withManagedIdentityId.SystemAssigned - Applied fixes across both NUnit and MSTest sample files and documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/loadtestservice/Azure.Developer.Playwright.NUnit/tests/samples/Sample2_CustomisingServiceParameters.cs | Updated ManagedIdentityCredential constructor calls in both SNIPPET and non-SNIPPET sections |
| sdk/loadtestservice/Azure.Developer.Playwright.MSTest/tests/samples/Sample2_CustomisingServiceParameters.cs | Updated ManagedIdentityCredential constructor call in AssemblyInitialize method |
| sdk/loadtestservice/Azure.Developer.Playwright.MSTest/samples/Sample2_CustomisingServiceParameters.md | Updated ManagedIdentityCredential constructor in documentation example |
Member
Author
|
CI failure due to #53859 |
scottaddie
approved these changes
Nov 13, 2025
JonathanCrd
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[error]/mnt/vss/_work/1/s/sdk/loadtestservice/Azure.Developer.Playwright.NUnit/tests/samples/Sample2_CustomisingServiceParameters.cs(39,21): error CS0618: 'ManagedIdentityCredential.ManagedIdentityCredential(string, TokenCredentialOptions)' is obsolete: 'Use constructor ManagedIdentityCredential(ManagedIdentityId id) or ManagedIdentityCredential(ManagedIdentityCredentialOptions options).' [/mnt/vss/_work/1/s/sdk/loadtestservice/Azure.Developer.Playwright.NUnit/tests/Azure.Developer.Playwright.NUnit.Tests.csproj::TargetFramework=net9.0] [error]/mnt/vss/_work/1/s/sdk/loadtestservice/Azure.Developer.Playwright.MSTest/tests/samples/Sample2_CustomisingServiceParameters.cs(30,75): error CS0618: 'ManagedIdentityCredential.ManagedIdentityCredential(string, TokenCredentialOptions)' is obsolete: 'Use constructor ManagedIdentityCredential(ManagedIdentityId id) or ManagedIdentityCredential(ManagedIdentityCredentialOptions options).' [/mnt/vss/_work/1/s/sdk/loadtestservice/Azure.Developer.Playwright.MSTest/tests/Azure.Developer.Playwright.MSTest.Tests.csproj::TargetFramework=net9.0]This PR is to fix the CI failure due to #53825