Fix: Make Name property settable in CosmosDBSqlRoleAssignment #48072
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a setter to the Name property to allow it to be set externally. - Removed the `isOutput: true` flag for the `_name` field in `DefineProvisionableProperties` to ensure the Name property can be included in the Bicep template. - Updated the XML comment for the Name property to reflect that it is now both gettable and settable. Fixes Azure#47979
AndriiLobanov
requested review from
JoshLove-msft,
tg-msft,
christothes and
KrzysztofCwalina
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @AndriiLobanov! We will review the pull request and get back to you soon. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isOutput: trueflag for the_namefield inDefineProvisionablePropertiesto ensure the Name property can be included in the Bicep template.Fixes #47979