Implement mgmt resource #47944
Merged
Implement mgmt resource #47944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
live1206
commented
Jan 23, 2025
•
live1206
commented
- Resolves Implement ResourceProvdier #47744
- Resolves Generate OperationSource in Azure plugin #48135
- Adjust to make MPG have similar file structure as DPG.
- Put CreateRequest methods from RestClientProvider to ClientProvider
- Implement client methods in Resource directly
- Omit RestClientProvider
- Add test to verify the generation
- Generated MgmtTypeSpec test can build now
- Put the logic of extracting resource metadata in emitter, it will be replaced with API from TypeSpec
github-actions
bot
added
Client
live1206
commented
Feb 8, 2025
eng/packages/http-client-csharp/generator/Azure.Generator/test/TestHelpers/Configuration.json
Outdated
Show resolved
Hide resolved
live1206
requested review from
JoshLove-msft,
m-nash,
jorgerangel-msft,
jsquire,
annelo-msft,
christothes,
KrzysztofCwalina,
tg-msft and
ArthurMa1978
as code owners
eng/packages/http-client-csharp/generator/Azure.Generator/src/ResourceBuilder.cs
Outdated
Show resolved
Hide resolved
eng/packages/http-client-csharp/generator/Azure.Generator/src/ResourceBuilder.cs
Outdated
Show resolved
Hide resolved
...enerator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/RestOperations/FoosRestOperations.cs
Show resolved
Hide resolved
m-nash
reviewed
Mar 5, 2025
eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
Outdated
Show resolved
Hide resolved
eng/packages/http-client-csharp/generator/Azure.Generator/src/AzureOutputLibrary.cs
Outdated
Show resolved
Hide resolved
...ackages/http-client-csharp/generator/Azure.Generator/src/Providers/ResourceClientProvider.cs
Outdated
Show resolved
Hide resolved
eng/packages/http-client-csharp/generator/Azure.Generator/src/ResourceBuilder.cs
Outdated
Show resolved
Hide resolved
eng/packages/http-client-csharp/generator/Azure.Generator/src/ResourceVisitor.cs
Outdated
Show resolved
Hide resolved
eng/packages/http-client-csharp/generator/Azure.Generator/src/Utilities/SingletonDetection.cs
Outdated
Show resolved
Hide resolved
...or/test/Providers/TestData/OperationSourceProviderTests/Verify_ResourceProviderGeneration.cs
Outdated
Show resolved
Hide resolved
live1206
commented
Mar 13, 2025
live1206
commented
Mar 13, 2025
...ackages/http-client-csharp/generator/Azure.Generator/src/Providers/ResourceClientProvider.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.