Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure/cosmos] fix changefeed iterator TimeOutError bug #32656

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

amanrao23
Copy link
Member

Packages impacted by this PR

@azure/cosmos

Issues associated with this PR

#32652

Describe the problem that is addressed by this PR

  • SDK is currently incorrectly handling TimeoutError in items.getChangeFeedIterator(). Empty response gets generated internally instead of throwing the error.
  • Fix unit test command

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@topshot99 topshot99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@topshot99 topshot99 merged commit 41ff17b into main Jan 28, 2025
11 checks passed
@topshot99 topshot99 deleted the cosmosdb/fix-ChangeFeed-TimoutError-issue branch January 28, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants