[Docs] improve rollup section of the bundling guide #32440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename `rollup.config.js` to `rollup.config.mjs` so it works regardless of the consuming package's module type - add a simpler configuration for packages that don't require polyfills/shims.
MaryGao
reviewed
Jan 7, 2025
- bring dependencies up to their latest versions - add `"type"="module"` for script blocks in HTML - remove tsc from parcel samples as transpilation is natively supported now - remove `"main": "index.js"` per parcel migration guide https://parceljs.org/getting-started/migration/#package.json%23main
v-jiaodi
reviewed
Jan 13, 2025
MaryGao
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks @jeremymeng for improving this and JiaoDi to help verify! LGTM :)~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename
rollup.config.jstorollup.config.mjsso it works regardless of theconsuming package's module type
add a simpler configuration for packages that don't require polyfills/shims.
change bundle output format from
iifetoesmformat as latter should be supported by recent browsers.