[NO REVIEW]fix duplicate records issue#49687
Closed
xinlian12 wants to merge 1 commit into
Closed
Conversation
xinlian12
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cosmos Spark connector’s readManyByPartitionKeys partition iterator to avoid invoking the underlying partition reader after it has already been closed, which can prevent post-close exceptions that may lead to Spark task retries and duplicate output records.
Changes:
- Added an
isClosedguard inhasNextto returnfalseimmediately when the iterator/reader has already been closed. - Kept the existing “close on completion / close on error / close when exhausted” behavior, but made
hasNextsafer after closure.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos-spark_3/src/main/scala/com/azure/cosmos/spark/CosmosReadManyByPartitionKeyReader.scala | Prevents hasNext from calling into a closed ItemsPartitionReaderWithReadManyByPartitionKey, reducing failures/retries that can cause duplicate records. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
+179
to
183
| } catch { | ||
| case error: Throwable => | ||
| closeReader() | ||
| throw error | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.