Skip to content

Storage - STG104 API Review Feedback#49666

Open
ibrandes wants to merge 4 commits into
Azure:feature/storage/stg104basefrom
ibrandes:stg104/APIViewChanges
Open

Storage - STG104 API Review Feedback#49666
ibrandes wants to merge 4 commits into
Azure:feature/storage/stg104basefrom
ibrandes:stg104/APIViewChanges

Conversation

@ibrandes

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Storage Blob append-block and page-upload APIs to incorporate STG104 API review feedback by moving optional parameters into options bags and passing required request body/range arguments explicitly, then aligns tests and stress scenarios to the new call patterns.

Changes:

  • Introduced new appendBlockWithResponse / uploadPagesWithResponse overloads that take required inputs (data/length, pageRange/body) separately from options bags.
  • Simplified AppendBlobAppendBlockOptions and PageBlobUploadPagesOptions into “optional settings only” types and updated internal call sites accordingly.
  • Updated upload/content-validation tests and stress tests to use the new overloads and options construction.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationUploadTests.java Updates sync content-validation tests to call the new overloads.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationAsyncUploadTests.java Updates async content-validation tests to call the new overloads.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/PageBlobClient.java Adds new sync uploadPagesWithResponse overload and deprecates older overload.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/PageBlobAsyncClient.java Adds new async uploadPagesWithResponse overload and refactors internal plumbing to use options bag.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobOutputStream.java Updates append/page output-stream internals to pass body separately and use the new options bags.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/AppendBlobClient.java Adds new sync appendBlockWithResponse overload and deprecates older overload.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/AppendBlobAsyncClient.java Adds new async appendBlockWithResponse overload and refactors internal plumbing to use options bag.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/options/PageBlobUploadPagesOptions.java Removes required-arg constructors; retains only optional settings (md5/conditions/validation algorithm).
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/options/AppendBlobAppendBlockOptions.java Removes required-arg constructors; retains only optional settings (md5/conditions/validation algorithm).
sdk/storage/azure-storage-blob/CHANGELOG.md Notes deprecations for older overloads (needs breaking-change callout given the signature/constructor removals).
sdk/storage/azure-storage-blob-stress/src/main/java/com/azure/storage/blob/stress/UploadPagesWithCRC64.java Updates stress scenario to use new page upload overload signature.
sdk/storage/azure-storage-blob-stress/src/main/java/com/azure/storage/blob/stress/AppendBlockWithCRC64.java Updates stress scenario to use new append-block overload signature.

Comment thread sdk/storage/azure-storage-blob/CHANGELOG.md
ibrandes and others added 2 commits July 2, 2026 11:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ibrandes ibrandes marked this pull request as ready for review July 2, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants