Stg102/datalake tags by browndav-msft · Pull Request #48057 · Azure/azure-sdk-for-java

browndav-msft · 2026-02-20T20:15:14Z

Cherry-picked the following commits from STG100 - Datalake tags

get tags
set tags
sas permissions for tag
adding tag to datalake sas model tests
adding sync directory tests (blob files were not commited)

…gs method

…n DataLakeTestBase This matches the behavior in BlobBaseTest https://github.com/Azure/azure-sdk-for-java/blob/a86d1fbe0002f087552c78e32df5447665d53939/sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobTestBase.java#L202 - This adds x-ms-blob-if-modified/unmodified. Four tests use NEW_DATE and OLD_DATE, which change the date in the header. We can't change this because the data comes from a supplier that is used by other tests and the other tests pass. - The reason we have to do this is because getTagsWithResponse and setTagsWithResponse both delegate to blockBlobClient, which uses instead of like the rest of DFS.

github-actions · 2026-02-23T20:10:41Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-storage-file-datalake

Copilot

Pull request overview

This PR cherry-picks the “Datalake tags” work into this branch, adding tag support to the Data Lake path APIs (directory/file) and updating SAS permission models and tests accordingly.

Changes:

Added getTags/setTags APIs (sync + async) for Data Lake paths, with request-conditions options types.
Extended SAS permission models/tests to support tags permission (t).
Added/updated directory tag tests (including OAuth, lease, and SAS scenarios) and test utilities.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
sdk/storage/azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/DirectoryApiTests.java	Adds coverage for get/set tags across auth/lease/SAS scenarios and access-condition cases.
sdk/storage/azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/DataLakeTestBase.java	Adds a helper to generate tags and updates test playback matching headers.
sdk/storage/azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/DataLakeServiceSasModelsTests.java	Updates SAS permission parse/toString tests to include tags permission.
sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/PathSasPermission.java	Adds `t` (tags) permission support to path SAS permission model.
sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/FileSystemSasPermission.java	Adds `t` (tags) permission support to filesystem SAS permission model.
sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeSetTagsOptions.java	Introduces options bag for set-tags including request conditions.
sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeGetTagsOptions.java	Introduces options bag for get-tags including request conditions.
sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java	Adds sync `getTags`/`setTags` APIs delegating to the underlying blob client.
sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java	Adds async `getTags`/`setTags` APIs delegating to the underlying blob async client.
sdk/storage/azure-storage-file-datalake/assets.json	Updates assets tag for test recordings/assets.

...-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java

...age-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java

Copilot · 2026-02-24T23:52:33Z

...e-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/DirectoryApiTests.java

+    public void getTagsAC() {
+        Map<String, String> t = getTags();
+        dc.setTags(t);
+
+        String leaseID = setupPathLeaseCondition(dc, RECEIVED_LEASE_ID);
+        DataLakeRequestConditions dac = new DataLakeRequestConditions().setLeaseId(leaseID);


getTagsAC is annotated as a @ParameterizedTest with a @MethodSource("modifiedMatchAndLeaseIdSupplier"), but the test method doesn't declare any parameters. JUnit will fail to resolve arguments at runtime. Either remove @ParameterizedTest/@MethodSource (make it a regular @Test) or add the expected parameters and use them to populate the DataLakeRequestConditions (similar to setTagsAC).

Suggested change

public void getTagsAC() {

Map<String, String> t = getTags();

dc.setTags(t);

String leaseID = setupPathLeaseCondition(dc, RECEIVED_LEASE_ID);

DataLakeRequestConditions dac = new DataLakeRequestConditions().setLeaseId(leaseID);

public void getTagsAC(OffsetDateTime modified, OffsetDateTime unmodified, String match, String noneMatch,

String leaseID) {

Map<String, String> t = getTags();

dc.setTags(t);

DataLakeRequestConditions dac = new DataLakeRequestConditions()

.setLeaseId(setupPathLeaseCondition(dc, leaseID))

.setIfMatch(setupPathMatchCondition(dc, match))

.setIfNoneMatch(noneMatch)

.setIfModifiedSince(modified)

.setIfUnmodifiedSince(unmodified);

Copilot · 2026-02-24T23:52:34Z

...age-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java

+     */
+    @ServiceMethod(returns = ReturnType.SINGLE)
+    public Mono<Void> setTags(Map<String, String> tags) {
+        return this.setTagsWithResponse(new DataLakeSetTagsOptions(tags)).map(Response::getValue);


setTags returns Mono<Void> but maps Response::getValue, which will be null for Response<Void>. Reactor doesn't allow emitting null, so this will likely fail with an NPE when subscribed. Use the same pattern as other void-returning APIs in this client (e.g., setMetadata): convert the Mono<Response<Void>> to a completion-only Mono<Void> (such as flatMap(FluxUtil::toMono) or then()).

Suggested change

return this.setTagsWithResponse(new DataLakeSetTagsOptions(tags)).map(Response::getValue);

return this.setTagsWithResponse(new DataLakeSetTagsOptions(tags))

.flatMap(FluxUtil::toMono);

Copilot · 2026-02-24T23:52:34Z

...le-datalake/src/test/java/com/azure/storage/file/datalake/DataLakeServiceSasModelsTests.java


    private static Stream<Arguments> sasPermissionsToStringSupplier() {
        return Stream.of(
            // read | write | delete | create | add | list | move | execute | owner | permission || expectedString


The argument table comment above sasPermissionsToStringSupplier() doesn't reflect the added tag parameter/column anymore. Updating it to include the tag flag will keep the test data easier to read and maintain.

Suggested change

// read | write | delete | create | add | list | move | execute | owner | permission || expectedString

// read | write | delete | create | add | list | move | execute | owner | permission | tag || expectedString

...-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java

ibrandes

looks good, just a couple small suggestions. copilot had some relevant comments too

ibrandes · 2026-02-24T23:45:21Z

...e-datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeGetTagsOptions.java

+ * Extended options that may be passed when getting tags for a path.
+ */
+@Fluent
+public class DataLakeGetTagsOptions {


We can make this final; from the wise words of the azure sdk api view bot, "Consider making all classes final by default - only make non-final if subclassing is supported."

ibrandes · 2026-02-24T23:45:41Z

...e-datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeSetTagsOptions.java

+ * Extended options that may be passed when setting tags for a path.
+ */
+@Fluent
+public class DataLakeSetTagsOptions {


Also can be final.

ibrandes and others added 5 commits February 20, 2026 14:47

get tags

0b89f95

set tags

8127a5e

sas permissions for tag

e3989c5

adding tag to datalake sas model tests

4c765d4

add only datalake files from 38db6fd

2ef3d71

github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Feb 20, 2026

browndav-msft added 20 commits February 20, 2026 16:17

fix linting errors:remove unused imports, add return annotation setTa…

7c282bb

…gs method

fix sasPermissionsParseSupplier test

e8d6e59

recorded tests for DirectoryApiTests.getSetTags()

661ace4

split getSetTagsAC into getTagsAC and setTagsAC

03afd46

record tests for getTagsAC and setTagsAC

a18b53f

change generatePathName() to dc.getDirectoryPath

95ddef5

create recordings for getSetTagsDirectorySas

aa462d4

Record DirectoryApiTests#getSetTagsOAuth

ed23d3b

Record DirectoryApiTests#getSetTagsLease

7b0c8b9

Record DirectoryApiTests#getTagsLeaseFailed

7a7b517

Record DirectoryApiTests#setTagsLeaseFailed

63e09fc

Record DirectoryApiTests#getSetTagsFileSystemSas

453a093

Record DirectoryApiTests#getSetTagsAccountSas

de14786

Record DirectoryApiTests#getSetTagsDirectoryIdentitySas

14c325c

Record DirectoryApiTests#getSetTagsFileSystemIdentitySas

b0b451a

Record DirectoryApiTests#getTagsError

54757b1

Record DirectoryApiTests#setTagsError

357bc84

Record DirectoryApiTests#setTagsACFail

f15d4ad

Record DirectoryApiTests#getTagsACFail

af7713f

browndav-msft changed the base branch from main to feature/storage/stg102base February 23, 2026 20:16

ibrandes marked this pull request as ready for review February 24, 2026 23:37

ibrandes requested a review from alzimmermsft as a code owner February 24, 2026 23:37

ibrandes requested review from a team, gunjansingh-msft, ibrandes, kyleknap and seanmcc-msft as code owners February 24, 2026 23:37

ibrandes requested a review from Copilot February 24, 2026 23:47

Copilot started reviewing on behalf of ibrandes February 24, 2026 23:48 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

ibrandes reviewed Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Stg102/datalake tags#48057

Stg102/datalake tags#48057
browndav-msft wants to merge 25 commits intoAzure:feature/storage/stg102basefrom
browndav-msft:stg102/datalakeTags

browndav-msft commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Uh oh!

ibrandes left a comment •

edited

Loading

Uh oh!

ibrandes Feb 24, 2026

Uh oh!

ibrandes Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return this.setTagsWithResponse(new DataLakeSetTagsOptions(tags)).map(Response::getValue);
	return this.setTagsWithResponse(new DataLakeSetTagsOptions(tags))
	.flatMap(FluxUtil::toMono);

	// read \| write \| delete \| create \| add \| list \| move \| execute \| owner \| permission \|\| expectedString
	// read \| write \| delete \| create \| add \| list \| move \| execute \| owner \| permission \| tag \|\| expectedString

Comments

Conversation

browndav-msft commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

API Change Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ibrandes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ibrandes Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

ibrandes Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ibrandes left a comment •

edited

Loading