Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps search 2025 01 01 #32091

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Maps search 2025 01 01 #32091

merged 4 commits into from
Jan 17, 2025

Conversation

gigigoo0
Copy link
Member

@gigigoo0 gigigoo0 commented Jan 10, 2025

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Copy link

openapi-pipeline-app bot commented Jan 10, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jan 10, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jan 10, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

AsyncBatchManagement-Search

@gigigoo0 gigigoo0 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 10, 2025
@gigigoo0 gigigoo0 marked this pull request as ready for review January 10, 2025 07:55
@gigigoo0 gigigoo0 requested a review from a team as a code owner January 10, 2025 07:55
@gigigoo0 gigigoo0 requested review from DominikMe and weidongxu-microsoft and removed request for a team January 10, 2025 07:55
@gigigoo0 gigigoo0 requested a review from mikekistler January 13, 2025 01:35
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jan 14, 2025

Do we have a review schedule for this stable api-version? I didn't find it in links/comments within this PR.

(wanted to find what was already be discussed, what's new in this version, etc.)

@gigigoo0
Copy link
Member Author

Do we have a review schedule for this stable api-version? I didn't find it in links/comments within this PR.

(wanted to find what was already be discussed, what's new in this version, etc.)

Requested an offline review on teams channel since we're only adding new response properties.

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve if streetName and streetNumber is the only change upon previous stable.

Note that a version (2024-04-01-preview) that not released SHOULD NOT be merged into main.

@mikekistler mikekistler added the offline-review-requested Service team has requested PR review be conducted offline. label Jan 15, 2025
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@mikekistler mikekistler added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Jan 15, 2025
@gigigoo0 gigigoo0 force-pushed the maps-search-2025-01-01 branch from 454d3c0 to 249ecd2 Compare January 17, 2025 02:51
@gigigoo0 gigigoo0 merged commit 1ba4596 into Azure:main Jan 17, 2025
28 of 29 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
* base commit

* Add version 2025-01-01

* update readme

* update cspell config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. data-plane Maps new-api-version offline-review-requested Service team has requested PR review be conducted offline. PublishToCustomers Acknowledgement the changes will be published to Azure customers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants