Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2025 03 01 stable #32062

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Feature/2025 03 01 stable #32062

merged 12 commits into from
Jan 16, 2025

Conversation

tejasm-microsoft
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-12-18-preview to stable/2025-03-01.
Copy link

openapi-pipeline-app bot commented Jan 9, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jan 9, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/quota/armquota There is no API change compared with the previous version
Java azure-resourcemanager-quota https://apiview.dev/Assemblies/Review/3820744e9b174f1db39817eaf9819e47?revisionId=35b98a14a9934dbcb69484e94b7f9374
Python azure-mgmt-quota https://apiview.dev/Assemblies/Review/f8941fa3a9484b72be3d49015218f7fb?revisionId=6050ca368bc44d85946f66e0e9b74af9
.Net Azure.ResourceManager.Quota https://apiview.dev/Assemblies/Review/9eae2f6971e14eb38ccddc391596f535?revisionId=3979e5d5e8f64e39a43482192fba1cd9

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jan 9, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 9, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Quota

@razvanbadea-msft
Copy link
Contributor

Fix the required SpellCheck / SpellCheck (pull_request) check

@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 10, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2025
@razvanbadea-msft
Copy link
Contributor

added the sign off as it is only promoting a preview version as stable, but to be able to merge fix the spellcheck

Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@tejasm-microsoft tejasm-microsoft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 15, 2025
@tejasm-microsoft tejasm-microsoft removed the request for review from gyprakas January 15, 2025 23:42
@tejasm-microsoft tejasm-microsoft merged commit 0d99a63 into main Jan 16, 2025
27 of 29 checks passed
@tejasm-microsoft tejasm-microsoft deleted the feature/2025-03-01-stable branch January 16, 2025 00:20
tejasm-microsoft added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants