Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory & Synapse] Update Oracle Linked Service #32060

Merged
merged 19 commits into from
Jan 26, 2025

Conversation

Yao725
Copy link
Member

@Yao725 Yao725 commented Jan 9, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Jan 9, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jan 9, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/datafactory/armdatafactory There is no API change compared with the previous version
Java azure-resourcemanager-datafactory https://apiview.dev/Assemblies/Review/57629460fae04223a2b478b7b73ead0f?revisionId=79d817b77ad24f559295b7b1fb79d033
.Net Azure.ResourceManager.DataFactory https://apiview.dev/Assemblies/Review/0dd9c8d2e38f4cd6981a3618a4a2dd86?revisionId=3780422c04e740f895be3e45ddbd4ebf

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 9, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.DataFactory
Microsoft.Synapse

@JeffreyRichter JeffreyRichter added the Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 9, 2025
@Yao725
Copy link
Member Author

Yao725 commented Jan 10, 2025

/azp run

Copy link

Commenter does not have sufficient privileges for PR 32060 in repo Azure/azure-rest-api-specs

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jan 10, 2025
Copy link

Commenter does not have sufficient privileges for PR 32060 in repo Azure/azure-rest-api-specs

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jan 16, 2025
@ruowan ruowan removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 16, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 16, 2025
@ms-bogdan-rotaru
Copy link
Contributor

/azp run

Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Copy link

Pull request contains merge conflicts.

"x-ms-format": "dfe-bool",
"description": "Specifies whether to use the Version 1.0 data type mappings. Do not set this to true unless you want to keep backward compatibility with Version 1.0's data type mappings, default value is false. Type: boolean. Only used for Version 2.0."
},
"fetchTswtzAsTimestamp": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchTswtzAsTimestamp

Abbreviations may create ambiguity. Can we remove the abbreviation and instead use something like "fetchTimestampWithTimezoneAsTimestamp" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of abbreviations is intentional here. This property is used to provide backward compatibility support and the name has been in our service for a long time and has been used extensively by customers. thanks.

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 16, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 16, 2025
@Yao725 Yao725 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 17, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 17, 2025
@Jingshu918 Jingshu918 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 20, 2025
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 25, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 25, 2025
@Yao725 Yao725 merged commit 709b04c into Azure:main Jan 26, 2025
27 of 29 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
* update Oracle linked service

* minor change

* fix spell check

* update description

* update properties to camel case

* revert cspell change to test

* bring spell check back

* fix

* fix spell error

---------

Co-authored-by: Mike Harder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants