Support -DryRun and -ExportBicep for Compute, Storage and Network specific commands #28833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoriZC
requested review from
DanielMicrosoft,
Pan-Qi,
VeryEarly,
YanaXu,
audreyttt,
dolauli,
haagha,
isra-fel,
notyashhh,
ookoka,
vidai-msft and
wyunchi-ms
as code owners
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a shared WhatIf formatting library for Azure PowerShell and integrates DryRun functionality across Compute, Storage, and Network modules. The shared library provides reusable formatters, models, and utilities for consistent WhatIf output formatting across different resource provider modules.
Key Changes
- Added a comprehensive shared WhatIf library with formatters, models, extensions, comparers, and utilities
- Integrated DryRun functionality in Compute, Storage, and Network modules with HTTP-based preview capabilities
- Added Bicep template export functionality for DryRun operations
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/WhatIf/Utilities/ResourceIdUtility.cs | New utility class for parsing Azure resource IDs |
| src/shared/WhatIf/Formatters/*.cs | Core formatting classes for colored console output |
| src/shared/WhatIf/Models/*.cs | Interface definitions and enums for WhatIf operations |
| src/shared/WhatIf/Extensions/*.cs | Extension methods for type conversions |
| src/shared/WhatIf/Comparers/*.cs | Comparer classes for sorting change types |
| src/shared/WhatIf/*.md | Documentation files (README, usage examples, integration guides) |
| src/Compute/Compute/Common/ComputeClientBaseCmdlet.cs | Added DryRun functionality with WhatIf adapter classes |
| src/Storage/Storage.Management/StorageAccount/StorageAccountBaseCmdlet.cs | Added DryRun functionality mirroring Compute implementation |
| src/Network/Network/VirtualNetwork/VirtualNetworkBaseCmdlet.cs | Added DryRun functionality mirroring Compute implementation |
| src/*/Compute.csproj, Storage.Management.csproj, Network.csproj | Added shared WhatIf library references |
VeryEarly
reviewed
Nov 10, 2025
VeryEarly
reviewed
Nov 10, 2025
Collaborator
There was a problem hiding this comment.
- considering there are active preview versions for storage and network, the base branch should be a combination of https://github.com/Azure/azure-powershell/tree/Az.Storage-preview and https://github.com/Azure/azure-powershell/tree/Az.Network-preview instead of main
VeryEarly
reviewed
Nov 10, 2025
| <PackageReference Include="System.Management" Version="4.5.0" /> | ||
| <!-- Include the following DLLs for security issue --> | ||
| <PackageReference Include="System.Security.Cryptography.Xml" Version="4.7.1" /> | ||
| <PackageReference Include="Azure.Identity" Version="1.11.4" /> |
Collaborator
There was a problem hiding this comment.
is this necessary? I thought azure identity will be brought in by az.accounts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.