[Az.ServiceFabric] Add parameters to New-AzServiceFabricManagedCluster, Set-AzServiceFabricManagedCluster, New-AzServiceFabricManagedNodeType, and Set-AzServiceFabricManagedNodeType
#28591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added parameters `-EnableAutoOsUpgrde` and `-AllowRdpAccess` to `New-AzServiceFabricManagedCluster` and `Set-AzServiceFabricManagedCluster`. * Added parameters `-ZoneBalance`, `-AllowOverProvisioning`, and `-Zones` to `New-AzServiceFabricManagedNodeType` and `Set-AzServiceFabricManagedNodeType`.
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
requested changes
Sep 19, 2025
Done |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
LukeSlev
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds new parameters to Service Fabric managed cluster and node type cmdlets to provide additional configuration options. The changes enhance the capabilities for managing OS upgrades, RDP access, and availability zone configurations.
- Added
-EnableAutoOsUpgradeand-AllowRdpAccessparameters to cluster management cmdlets - Added
-ZoneBalance,-EnableOverProvisioning, and-Zoneparameters to node type management cmdlets - Updated help documentation and tests to support the new parameters
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| NewAzServiceFabricManagedCluster.cs | Added EnableAutoOsUpgrade and AllowRdpAccess switch parameters |
| SetAzServiceFabricManagedCluster.cs | Added EnableAutoOsUpgrade and AllowRdpAccess nullable bool parameters |
| NewAzServiceFabricManagedNodeType.cs | Added ZoneBalance, EnableOverProvisioning switch parameters and Zone list parameter |
| SetAzServiceFabricManagedNodeType.cs | Added ZoneBalance, EnableOverProvisioning nullable bool parameters and Zone list parameter |
| PSManagedNodeType.cs | Updated constructor to include all new properties from NodeType |
| Help files | Updated documentation for all new parameters |
| Test files | Added comprehensive test coverage for new functionality |
| ChangeLog.md | Documented the new parameter additions |
src/ServiceFabric/ServiceFabric/help/Set-AzServiceFabricManagedNodeType.md
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-EnableAutoOsUpgrdeand-AllowRdpAccesstoNew-AzServiceFabricManagedClusterandSet-AzServiceFabricManagedCluster.-ZoneBalance,-AllowOverProvisioning, and-ZonetoNew-AzServiceFabricManagedNodeTypeandSet-AzServiceFabricManagedNodeType.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.