Add MemorySizeInGB parameter for SQL Managed Instance CRUD #28341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
UrosKrsticMIPerf
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ught when an instance doesn't exist and update comments regarding the MemorySizeInGB parameter. Update tests that are failing
…in New Instance cmdlet for Memory parameter
UrosKrsticMIPerf
requested review from
wyunchi-ms,
dolauli,
isra-fel,
VeryEarly,
YanaXu,
vidai-msft,
NoriZC,
notyashhh and
Pan-Qi
as code owners
UrosKrsticMIPerf
force-pushed
the
dev/uroskrstic/add-memorysizeingb-for-sqlmi
branch
3 times, most recently
from
332864d to
a0aba90
Compare
|
Hi @UrosKrsticMIPerf Please help resolve the conflicts as I do not have write permission to your branch |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@NoriZC I've resolved the conflicts. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the MemorySizeInGB parameter to SQL Managed Instance CRUD operations (New, Set, Get cmdlets), enabling the creation and management of instances with flexible memory configurations. This feature is being added as a public preview capability.
Key Changes
- Added MemorySizeInGB parameter to New-AzSqlInstance and Set-AzSqlInstance cmdlets
- Updated the model to include MemorySizeInGB property for managed instances returned by Get-AzSqlInstance
- Added comprehensive test coverage for the new functionality with both positive and negative test scenarios
Reviewed Changes
Copilot reviewed 14 out of 38 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Sql/Sql/help/Set-AzSqlInstance.md | Updated documentation to include MemorySizeInGB parameter and example usage |
| src/Sql/Sql/help/New-AzSqlInstance.md | Updated documentation to include MemorySizeInGB parameter and example usage |
| src/Sql/Sql/help/Get-AzSqlInstance.md | Updated documentation to show MemorySizeInGB field in output examples |
| src/Sql/Sql/ManagedInstance/Services/AzureSqlManagedInstanceAdapter.cs | Added MemorySizeInGB mapping between model and SDK |
| src/Sql/Sql/ManagedInstance/Model/AzureSqlManagedInstanceModel.cs | Added MemorySizeInGB property to the model |
| src/Sql/Sql/ManagedInstance/Cmdlet/SetAzureSqlManagedInstance.cs | Added MemorySizeInGB parameter and logic to Set cmdlet |
| src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs | Added MemorySizeInGB parameter and logic to New cmdlet |
| src/Sql/Sql/ChangeLog.md | Added changelog entries for the new feature |
| src/Sql/Sql.Test/ScenarioTests/ManagedInstanceCrudScenarioTests.ps1 | Added new test functions for flexible memory testing |
| src/Sql/Sql.Test/ScenarioTests/ManagedInstanceCrudScenarioTests.cs | Added test method registrations for flexible memory tests |
| src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseMoveCopyTests.ps1 | Updated test to use proper resource creation/cleanup |
| src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1 | Updated test to use proper resource creation/cleanup |
| src/Sql/Sql.Test/ScenarioTests/Common.ps1 | Added new test parameter functions and updated helper function signature |
| src/Sql/Sql.Management.Sdk/README.md | Updated SDK reference to newer API version |
src/Sql/Sql/ManagedInstance/Cmdlet/SetAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28341 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
NoriZC
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added MemorySizeInGB parameter for SQL Managed Instance to the New, Set and Get cmdlets.
Fixed existing and added new tests.
Update Change.md.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.