Network Fabric 2024-06-15-preview #27973
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR previews the Managed Network Fabric API for the 2024-06-15 release, updating versions and adding new post-action cmdlets.
- Bumps all UX JSON files'
apiVersionto2024-06-15-preview - Introduces three new operations (
ArmConfigurationDiff,CommitConfiguration,DeviceConfiguration) undernetworkFabrics.json - Updates Autorest README (pin commit, add tag/input-file, adjust directives) and adds
AssemblyInfo.cswith version 0.1.3
Reviewed Changes
Copilot reviewed 317 out of 317 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| *.json (multiple under UX/Microsoft.ManagedNetworkFabric) | Updated "apiVersion" from 2023-06-15 to 2024-06-15-preview across all resource types |
| src/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/UX/Microsoft.ManagedNetworkFabric/networkFabrics.json | Added Invoke-AzNetworkFabricArmConfigurationDiff, Invoke-AzNetworkFabricCommitConfiguration, and Invoke-AzNetworkFabricDeviceConfiguration cmdlet entries |
| src/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/README.md | Pinned new swagger commit, added preview tag and input-file, commented out some directives, and extended directive mappings |
| src/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/Properties/AssemblyInfo.cs | Added auto-generated assembly metadata and bumped file/module version to 0.1.3 |
Comments suppressed due to low confidence (3)
src/ManagedNetworkFabric/ManagedNetworkFabric/ChangeLog.md:3
- Add entries for the API version bump and the newly introduced cmdlets under the
## Upcoming Releaseheader to capture these changes in the changelog.
## Upcoming Release
src/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/UX/Microsoft.ManagedNetworkFabric/networkFabrics.json:47
- New post-action cmdlets are added here; ensure you include unit or integration tests covering these operations to maintain test coverage.
"name": "Invoke-AzNetworkFabricArmConfigurationDiff"
src/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/README.md:41
- The
module-versionin the README is set to0.1.0but the generated AssemblyInfo specifies0.1.3; consider aligning these to avoid versioning confusion.
module-version: 0.1.0
vidai-msft
requested changes
Jun 17, 2025
There was a problem hiding this comment.
Please fix the following issues in this PR.
- Examples are required for each cmdlet. Please fill in them in those under the examples folder and then run build-module.ps1 to consolidate into the docs and helps.
- Many new cmdlets are missing test cases. Please add at least 1 test case for each cmdlet. If for some reason, a cmdlet cannot be recorded or played back, leave the test script there and mark the test as -Tag "LiveOnly".
- generate-info.json is critical for PR validation, please upload this file as well.
src/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/generate-info.json
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
nafizhaider32
requested review from
wyunchi-ms,
dolauli and
isra-fel
as code owners
|
@nafizhaider32 Please revert the changes that are not related to ManagedNetworkFabric. |
added 2 commits
June 18, 2025 09:22
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.