[Az.DigitalTwins] Update generation tool version: autorest.powershell v3->v4 #27899
Conversation
… jinpei/main/DigitalTwins-v4
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Az.DigitalTwins generation tool from autorest.powershell v3 to v4. It adjusts documentation files, parameter sets, command syntax (including new JSON‐based input modes), and associated custom scripts to align with the new version.
Reviewed Changes
Copilot reviewed 84 out of 84 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Docs files (e.g., New-AzDigitalTwinsTimeSeriesDatabaseConnection.md, New-AzDigitalTwinsInstance.md, etc.) | Updated cmdlet syntaxes, parameter set names, and removed deprecated help files (e.g., PrivateLink and PrivateEndpointConnection docs) to align with v4 changes. |
| Custom script files (e.g., Update-AzDigitalTwinsTimeSeriesDatabaseConnection.ps1, Update-AzDigitalTwinsEndpoint.ps1, New-AzDigitalTwinsEndpoint.ps1, etc.) | Adjustments in parameter handling and property assignment to support new input modes and updated API models. |
| AssemblyInfo.cs and README.md | Updated version information and transformation directives to reflect the upgrade and removal of deprecated commands. |
Comments suppressed due to low confidence (1)
src/DigitalTwins/DigitalTwins.Autorest/README.md:51
- Ensure that the removal of deprecated command directives (e.g., for PrivateLink and PrivateEndpointConnection resources) is intentional and documented for users migrating from v3 to v4, to avoid any unexpected loss of functionality or guidance.
- hide: true
|
|
||
| process { | ||
| try { | ||
| if($PSBoundParameters['EndpointType'] -eq 'EventHub') |
There was a problem hiding this comment.
Please verify that the parameter names used for the EventHub connection keys (e.g., 'connectionStringPrimaryKey' vs. 'ConnectionStringPrimaryKey') are consistent across both parameter definitions and property assignments. Although PowerShell is case-insensitive, using a consistent naming style improves code readability and maintainability.
Copilot uses AI. Check for mistakes.
| @@ -51,36 +51,33 @@ DotNetFrameworkVersion = '4.7.2' | |||
| # ProcessorArchitecture = '' | |||
|
|
|||
| # Modules that must be imported into the global environment prior to importing this module | |||
| RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '4.0.1'; }) | |||
| RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '5.0.2'; }) | |||
There was a problem hiding this comment.
The current Az.Accounts version is 5.1.0. Should we update it here?
… jinpei/main/DigitalTwins-v4
…3->v4
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.