first init- without record test since we are aiting for SDK 186

[yaarark]

Description

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[Copilot]

Pull Request Overview

This PR extends the functionality of the Application Gateway Firewall custom rule command to support additional variable names.

• Updated help documentation and the ValidateSet attribute to include "ClientAddrXFFHeader" and "GeoLocationXFFHeader".
• Revised ChangeLog.md to document the new properties and a corresponding bug fix.
• Added new scenario tests (PowerShell and C#) to cover the additional custom rule variable functionality.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Network/Network/help/New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md	Updated help text with new accepted values.
src/Network/Network/FirewallPolicy/FirewallCustomRule/GroupByUserSession/GroupByVariable/NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs	Extended ValidateSet to include new variable names.
src/Network/Network/ChangeLog.md	Added changelog entries documenting the new variables and bug fix.
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1	Added PowerShell scenario tests for custom rule variable functionality.
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.cs	Updated test runner to include new test scripts.

[Copilot]

The changelog entry mentions adding 'GeoLocation' as a valid input, but the code and help updates reference 'GeoLocationXFFHeader'. Please update the changelog for consistency with the new accepted values.

[vidai-msft]

Please update the change log to make it consistent with the change.

[vidai-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[vidai-msft]

Please update the change log to make it consistent with the change.

[github-actions]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

[vidai-msft]

@yaarark If you add new test cases, please record it from your local and then include the json files in the PR as well.

[YanaXu]

Hi @yaarark , I've converted this PR to draft. Please update it as ready when your fix the CI errors.

[isra-fel]

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀

[yoavmal]

Closing this PR. Changes moved to this PR.