Skip to content

Compute t1 test 3 #27827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Compute t1 test 3 #27827

wants to merge 24 commits into from

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented May 22, 2025

Description

this PR reflects, two major updates:

after TypeSpec migration, there were many directives that needed to be added and
it kept running into "maximum calls reached" (stack overflow).

I had a meeting with several track 1 SMEs, and they said it is a known autorest 2 issue and will not be addressed. But Compute still has track 1 dependency so the best solution I found, and they suggested the same thing, is to keep the swagger json within the PS repo and do in place file manipulation with file I added: preprocess-rest-api-spec.ps1 To avoid some of the directives
 

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@grizzlytheodore grizzlytheodore marked this pull request as ready for review June 26, 2025 20:34
@Copilot Copilot AI review requested due to automatic review settings June 26, 2025 20:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to remove a number of legacy or unused customization files and refactor some constructors in the Compute Management SDK for virtual machine operations. Key changes include:

  • Removal of multiple files (e.g. VirtualMachinesOperationsExtensions, CloudServiceNetworkProfile, IVirtualMachinesOperations, etc.) that are likely no longer needed.
  • Constructor refactoring in VirtualMachineScaleSetVMExtension with a renaming of a parameter from "type1" to "virtualMachineExtensionPropertiesType", and a base type change in DiskRestorePoint.
  • A minor csproj file update.

Reviewed Changes

Copilot reviewed 13 out of 412 changed files in this pull request and generated 1 comment.

File Description
VirtualMachinesOperationsExtensions.cs, VirtualMachinesOperations.cs, VirtualMachineScaleSetExtensionUpdate.cs, VirtualMachineCaptureResult.cs, SubResourceWithColocationStatus.cs, NetworkInterfaceReference.cs, IVirtualMachinesOperations.cs, DiskEncryptionSetParameters.cs, CloudServiceNetworkProfile.cs Files removed for cleanup of legacy customizations.
VirtualMachineScaleSetVMExtension.cs Constructor parameter "type1" renamed to "virtualMachineExtensionPropertiesType", with a potential bug in property assignment for Location.
DiskRestorePoint.cs Base class changed from ProxyOnlyResource to ProxyResource.
Compute.Management.Sdk.csproj Minor update to the project file formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant