-
Notifications
You must be signed in to change notification settings - Fork 4k
Compute t1 test 3 #27827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grizzlytheodore
wants to merge
24
commits into
main
Choose a base branch
from
compute-t1Test-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compute t1 test 3 #27827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to remove a number of legacy or unused customization files and refactor some constructors in the Compute Management SDK for virtual machine operations. Key changes include:
- Removal of multiple files (e.g. VirtualMachinesOperationsExtensions, CloudServiceNetworkProfile, IVirtualMachinesOperations, etc.) that are likely no longer needed.
- Constructor refactoring in VirtualMachineScaleSetVMExtension with a renaming of a parameter from "type1" to "virtualMachineExtensionPropertiesType", and a base type change in DiskRestorePoint.
- A minor csproj file update.
Reviewed Changes
Copilot reviewed 13 out of 412 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
VirtualMachinesOperationsExtensions.cs, VirtualMachinesOperations.cs, VirtualMachineScaleSetExtensionUpdate.cs, VirtualMachineCaptureResult.cs, SubResourceWithColocationStatus.cs, NetworkInterfaceReference.cs, IVirtualMachinesOperations.cs, DiskEncryptionSetParameters.cs, CloudServiceNetworkProfile.cs | Files removed for cleanup of legacy customizations. |
VirtualMachineScaleSetVMExtension.cs | Constructor parameter "type1" renamed to "virtualMachineExtensionPropertiesType", with a potential bug in property assignment for Location. |
DiskRestorePoint.cs | Base class changed from ProxyOnlyResource to ProxyResource. |
Compute.Management.Sdk.csproj | Minor update to the project file formatting. |
src/Compute/Compute.Management.Sdk/Customizations/VirtualMachineScaleSetVMExtension.cs
Outdated
Show resolved
Hide resolved
…neScaleSetVMExtension.cs Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR reflects, two major updates:
after TypeSpec migration, there were many directives that needed to be added and
it kept running into "maximum calls reached" (stack overflow).
I had a meeting with several track 1 SMEs, and they said it is a known autorest 2 issue and will not be addressed. But Compute still has track 1 dependency so the best solution I found, and they suggested the same thing, is to keep the swagger json within the PS repo and do in place file manipulation with file I added: preprocess-rest-api-spec.ps1 To avoid some of the directives
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.