Skip to content

Conversation

@Balashivaram
Copy link

@Balashivaram Balashivaram commented May 13, 2025

Description

Azure Firewall team has made newer changes to feature Explicit Proxy. Explicit Proxy feature is already in Public Preview but the new changes will change the customer experience in using the Explicit Proxy feature. Due to this Explicit Proxy newer version is releasing again in Public preview and the new changes are added behind Feature Flag in all three places (Portal, Control Plane and Data Plane) and the new changes will be called by name Explicit Proxy V2. In Explicit Proxy V2 Version, removed HTTPs Port, instead of PAC File SAS URL customer needs to give PAC File URL with a managed identity which will have required roles to access the file

In the current PR to support Explicit Proxy V2 version, we have removed HTTPs Port Input, instead of PAC File SAS URL we will be getting PAC File URL as a input and a user Assigned Identity. Since Explicit Proxy is supported in Standard SKU, identity object has been removed from Premium property and customer can input multiple User Assigned Identities to support this User Assigned Identity parameter has been changes from String to Array of Strings

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution @Balashivaram! We will review the pull request and get back to you soon.

@wyunchi-ms wyunchi-ms closed this May 14, 2025
@wyunchi-ms wyunchi-ms reopened this May 14, 2025
Copy link
Contributor

@wyunchi-ms wyunchi-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the src/Network/Network/ChangeLog.md and put your messages right under the Upcoming Release

@github-actions
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

[ValidateNotNullOrEmpty]
public PSManagedServiceIdentity Identity { get; set; }

[Parameter(
Copy link
Contributor

@msJinLei msJinLei May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove the a parameter is a breaking change, which can only be release in the major release. The next one is in November.

@Balashivaram You can split the PR into breaking change commit and non-breaking change commit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msJinLei Does changing the parameter type will also be considered as removing the Parameter and adding a new Parameter? If yes, then this whole PR will be published in November release? And I am also removing one more parameter from Explicit Proxy object will that be also considered as a breaking change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Balashivaram a breaking change is simply a change that may break a script. Removing a parameter is definitely a breaking change, changing the type depends on whether the new type is compatible to the previous type. E.g. string[] to string is a breaking change but string to string[] is not.

@msJinLei msJinLei added Contains Breaking Change This PR contains breaking change and removed Waiting for CI :shipit: labels May 20, 2025
@github-actions
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@isra-fel
Copy link
Member

isra-fel commented Oct 1, 2025

@Balashivaram there hasn't been any updates to this PR since May. Please close it if you want to abandon it, or let me know if you don't.

@isra-fel
Copy link
Member

isra-fel commented Oct 3, 2025

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀

@isra-fel isra-fel closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants