Enable service client to set max retry-after times (#258)

* Enable service client to set max retry-after times after it is created by CreateCustomArmClient

* Add property names to AzureAccount to support new cetrificate authentication method

* Address review comments

Author: msJinLei

src/Authentication.Abstractions/AzureAccount.cs

@@ -148,7 +148,24 @@ public static class Property
         /// <summary>
         /// Secret that may be used with service principal login
         /// </summary>
-        ServicePrincipalSecret = "ServicePrincipalSecret";
+        ServicePrincipalSecret = "ServicePrincipalSecret",
+
+
+        /// <summary>
+        /// The path of certficate file in pem or pkcs#12 format
+        /// </summary>
+        CertificatePath = "CertificatePath",
+
+        /// <summary>
+        /// The password required to access the pkcs#12 certificate file
+        /// </summary>
+        CertificatePassword = "CertificatePassword",
+
+
+        /// <summary>
+        /// Specifies if the x5c claim (public key of the certificate) should be sent to the STS to achieve easy certificate rollover in Azure AD
+        /// </summary>
+        SendCertificateChain = "SendCertificateChain";
         }
     }
 }

src/Authentication.Abstractions/Extensions/ClientFactoryExtension.cs

@@ -0,0 +1,41 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System;
+
+namespace Microsoft.Azure.Commands.Common.Authentication.Abstractions
+{
+    public static class ServiceClientExtension
+    {
+        /// <summary>
+        /// Set max retry times of retry after handler that is used to handle the response with retry-after header
+        /// </summary>
+        /// <param name="retrytimes">Max retry times</param>
+        /// <returns>Whether succeed to set max retry times or not</returns>
+        public static bool SetMaxTimesForRetryAfterHandler<TClient>(this Microsoft.Rest.ServiceClient<TClient> serviceClient, uint retrytimes) where TClient : Microsoft.Rest.ServiceClient<TClient>
+        {
+            bool findRetryHandler = false;
+            foreach(var handler in serviceClient.HttpMessageHandlers)
+            {
+                var retryHandler = handler as Microsoft.Rest.RetryAfterDelegatingHandler;
+                if (retryHandler != null)
+                {
+                    retryHandler.MaxRetries = Convert.ToInt32(retrytimes);
+                    findRetryHandler = true;
+                }
+            }
+            return findRetryHandler;
+        }
+    }
+}

src/Dependencies.targets

@@ -8,7 +8,7 @@
     <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
   </ItemGroup>
   <ItemGroup>
-     <PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.20" />
+     <PackageReference Include="Microsoft.Rest.ClientRuntime" Version="2.3.23" />
  </ItemGroup>
   <ItemGroup Condition="'$(IncludeHyak)' == 'true'">
     <PackageReference Include="Microsoft.Azure.Common" Version="2.2.1" />