Async call in library should add ConfigureAwait(false) (#257)

Author: erich-wang

src/Authentication.Abstractions/AzureEnvironment.cs

@@ -212,7 +212,7 @@ private static async Task<List<ArmMetadata>> InitializeEnvironmentsFromArm(strin
             {
                 httpOperations = HttpClientOperationsFactory.Create().GetHttpOperations();
             }
-            var armResponseMessage = await httpOperations.GetAsync(armMetadataRequestUri);
+            var armResponseMessage = await httpOperations.GetAsync(armMetadataRequestUri).ConfigureAwait(false);
             if (armResponseMessage?.StatusCode != HttpStatusCode.OK)
             {
                 throw new Exception($"Failed to load cloud metadata from the url {armMetadataRequestUri}.");
@@ -222,7 +222,7 @@ private static async Task<List<ArmMetadata>> InitializeEnvironmentsFromArm(strin
 
             if (armResponseMessage.Content != null)
             {
-                armMetadataContent = await armResponseMessage.Content.ReadAsStringAsync();
+                armMetadataContent = await armResponseMessage.Content.ReadAsStringAsync().ConfigureAwait(false);
             }
             if (string.IsNullOrEmpty(armMetadataContent))
             {

src/Authentication.Abstractions/HttpClientOperationsFactory.cs

@@ -47,7 +47,7 @@ public HttpClientOperations(HttpClient client)
 
             public async Task<HttpResponseMessage> GetAsync(string requestUri)
             {
-                return await _client.GetAsync(requestUri);
+                return await _client.GetAsync(requestUri).ConfigureAwait(false);
             }
         }
     }