Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Quickstart to run commands, as opposed to just queries #418

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

yihezkel
Copy link
Member

@yihezkel yihezkel commented Feb 5, 2025

Fixed

Enable Quickstart to run commands, as opposed to just queries. I assume it previously worked, and I'm not sure why it stopped working.

Copy link

github-actions bot commented Feb 5, 2025

Test Results

332 tests  ±0   323 ✅ ±0   3m 38s ⏱️ +16s
 27 suites ±0     9 💤 ±0 
 27 files   ±0     0 ❌ ±0 

Results for commit ce5afc0. ± Comparison against base commit 56e0446.

♻️ This comment has been updated with latest results.

@AsafMah
Copy link
Contributor

AsafMah commented Feb 5, 2025

I think it might have to do with the 6.0.0 changes and the refactoring of the api to sync/async

@ohadbitt should also take a look

@yihezkel yihezkel requested review from AsafMah and ohadbitt February 5, 2025 16:53
@ohadbitt
Copy link
Collaborator

I think it might have to do with the 6.0.0 changes and the refactoring of the api to sync/async

@ohadbitt should also take a look

yes some bad refactor

@georgebanasios
Copy link
Contributor

georgebanasios commented Feb 10, 2025

I think this might have been removed in the past by mistake, because I don't see it even on the release prior to 6.0.0.

Edit: it was with the move to Azure client.
Prior to Azure client PR the quickstart had just .execute (which determined the command internally).

@AsafMah AsafMah merged commit 172140f into master Feb 12, 2025
8 checks passed
@yihezkel yihezkel deleted the enableQuickstartMgmtCommands branch February 12, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants