Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new runnable TS Samples Directory #465

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

hossam-nasr
Copy link
Contributor

TS version of #438. Resolves #421.

Copy link
Contributor

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as other samples PR. Overall structure looks good, but didn't review every single line of code

Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left a comment about your .csproj.

@hossam-nasr hossam-nasr force-pushed the hossamnasr/ts-samples branch from f559707 to 841a31c Compare February 7, 2023 22:58
@hossam-nasr hossam-nasr merged commit 9fb45a1 into v3.x Feb 7, 2023
@hossam-nasr hossam-nasr deleted the hossamnasr/ts-samples branch February 7, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants