Fix ShoppingOrchestration sample and make input optional to callEntity #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ShoppingOrchestration sample included generic typing of its
callEntityinvocations. This wouldn't compile, since no orchestration APIs use generic typing yet. It was probably a leftover from an earlier draft of this PR.This PR removes the generic typing.
Furthermore, I realized that the input parameter to
callEntitywas previously mandatory, which is awkward because not all calls tocallEntitynecessitate an input. I suspect some of our users might have been forced to pass innullorundefinedvalues in the past, or some other kind of default to get around it.This PR makes the
inputparameter tocallEntityto be optional.