Skip to content

Use p2p reference for external ext proj entry point #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 13, 2025
Merged

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Feb 5, 2025

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

  • Refactor the method for enabling external ext proj
    • This change was needed to include the ext proj in restore phase. It also is slightly more elegant.
  • GenerateExtensionProject target no longer builds, only generates the extension project
  • Adds more errors and warnings around correct configuration of external ext proj
    • Error if more than one external ext proj is referenced
    • Error if external ext proj does not exist (but is referenced)
    • Warning if external ext proj does not have ReferenceOutputAssemblies=false.
  • Removes Configuration=Release and ManagePackageVersionsCentrally=false from generated csproj
    • Configuration is passed in via global property for non-external scenarios
    • ManagePackageVersionsCentrally was moved to the list of remove-props
  • Add sample with docs around external ext proj
    • this will eventually be polished and included in official microsoft docs.
  • Update SDK version to 2.1.0-preview.1

@jviau jviau changed the title Update SDK version to 2.1.0-preview.1 Use p2p reference for external ext proj entry point Feb 6, 2025
@jviau jviau force-pushed the jviau/sdk/version branch from bfa64c2 to 3ae53e3 Compare February 6, 2025 19:53
@jviau jviau requested review from fabiocav and brettsam February 6, 2025 20:25
Copy link
Contributor

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looking at documentation. Initial pass. Mostly trying to understand the shape of things here.

Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok these docs are awesome...

@jviau jviau merged commit 78d152a into main Feb 13, 2025
28 checks passed
@jviau jviau deleted the jviau/sdk/version branch February 13, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants