-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Middleware sample to Net9 #2921
base: main
Are you sure you want to change the base?
Conversation
upgrades have caused side effects
Why does this sample need to be updated to net9? net8 is perfectly fine as far as I am concerned. |
Thank you @jviau for your feedback, as a contributor I would hope you will consider the upcoming end of support for the in-process AzFn model and consider that this PR is just a ahead of it's time, since eventually all the samples will need upgrading, not just to .Net9(+) but into the isolated model, since: “Support will end for the in-process model on November 10, 2026. We highly recommend that you migrate your apps to the isolated worker model for full support.” |
There's a lot of confusion here. Next, what @jviau was saying is that .NET 8 is an LTS while .NET 9 is an STS. .NET 8 will be supported longer than .NET 9. So given that .NET 9
There's no value in changing samples from .NET 8. Hope that clarifies it a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating this sample to .NET9 is not desired. If you want to proceed with this PR, please revert to .NET8 and address the other review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer gitignore changes in a separate PR.
<TargetFramework>net8.0</TargetFramework> | ||
<AzureFunctionsVersion>v4</AzureFunctionsVersion> | ||
<OutputType>Exe</OutputType> | ||
<TargetFramework>net9.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep the previous indentation style for this file (2 spaces, not 4)
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Upgrade middleware sample to .Net9 and sets static and sync methods and classes to async compatible
@jviau
@kshyju
resolves #2920
Pull request checklist
release_notes.md