Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/azd/pkg/pipeline/github_provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,10 @@ func (p *GitHubScmProvider) configureGitRemote(
}

// defines the structure of an ssl git remote
var gitHubRemoteGitUrlRegex = regexp.MustCompile(`^git@github\.com:(.*?)(?:\.git)?$`)
var gitHubRemoteGitUrlRegex = regexp.MustCompile(`^git@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}:(.*?)(?:\.git)?$`)

// defines the structure of an HTTPS git remote
var gitHubRemoteHttpsUrlRegex = regexp.MustCompile(`^https://(?:www\.)?github\.com/(.*?)(?:\.git)?$`)
var gitHubRemoteHttpsUrlRegex = regexp.MustCompile(`^https://(?:www\.)?[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}/(.*?)(?:\.git)?$`)

// ErrRemoteHostIsNotGitHub the error used when a non GitHub remote is found
var ErrRemoteHostIsNotGitHub = errors.New("not a github host")
Expand Down
2 changes: 1 addition & 1 deletion cli/azd/pkg/pipeline/github_provider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func Test_gitHub_provider_getRepoDetails(t *testing.T) {
t.Run("error", func(t *testing.T) {
provider := &GitHubScmProvider{}
ctx := context.Background()
details, e := provider.gitRepoDetails(ctx, "git@other.com:Azure/azure-dev.git")
details, e := provider.gitRepoDetails(ctx, "gt@other.com:Azure/azure-dev.git")
require.Error(t, e, ErrRemoteHostIsNotGitHub)
require.EqualValues(t, (*gitRepositoryDetails)(nil), details)
})
Expand Down
Loading