Skip to content

Use AzureCLI@2 and serviceConnection to run CI/CD tests instead of manually logging in az #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 2, 2024

Conversation

vhvb1989
Copy link
Member

@vhvb1989 vhvb1989 commented Jul 2, 2024

This PR removes the manual logging to az using client secrets.

Instead, it uses the Ado task AzureCLI@2 and a service connection. The login is scoped to the task now.

@vhvb1989
Copy link
Member Author

vhvb1989 commented Jul 2, 2024

/azp run azure-dev - cli

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@vhvb1989 vhvb1989 changed the title try fed cred for ci Use AzureCLI@2 and serviceConnection to run CI/CD tests instead of manually logging in az Jul 2, 2024
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you do the rollback that @wbreza mentioned. Thanks for fixing this!

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can azd-login.yml also be eliminated here?

@vhvb1989
Copy link
Member Author

vhvb1989 commented Jul 2, 2024

Can azd-login.yml also be eliminated here?

No. Maybe in the future, once we have an Azdo task to run azd. For now, azd needs to be manually logged in.

@vhvb1989
Copy link
Member Author

vhvb1989 commented Jul 2, 2024

/check-enforcer override

@vhvb1989
Copy link
Member Author

vhvb1989 commented Jul 2, 2024

/check-enforcer override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants