-
Notifications
You must be signed in to change notification settings - Fork 218
Use AzureCLI@2 and serviceConnection to run CI/CD tests instead of manually logging in az #4059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run azure-dev - cli |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once you do the rollback that @wbreza mentioned. Thanks for fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can azd-login.yml
also be eliminated here?
No. Maybe in the future, once we have an Azdo task to run azd. For now, azd needs to be manually logged in. |
/check-enforcer override |
/check-enforcer override |
…nually logging in az (#4059)
This PR removes the manual logging to
az
using client secrets.Instead, it uses the Ado task
AzureCLI@2
and a service connection. The login is scoped to the task now.