fix: endpointID for Stateless CNI should add ifName if the NiCType is…

[behzad-mir]

EndpointID for Stateless CNI should add ifName if the NiCType is Delegated to distinguish that from the InfraNIC endpoint.
The reason for this behavior is that Stateless CNI is using only ContainerID for the endpoint ID.

• uses conventional commit messages
• includes documentation
• adds unit tests
• relevant PR labels added

Notes:

[Copilot]

Pull Request Overview

This PR enhances the endpoint ID generation for Stateless CNI by including the interface name when the NIC type is Delegated, preventing collisions with InfraNIC endpoints.
Key changes:

• Extended the GetEndpointID signature to accept nicType and altered its behavior for DelegatedVMNIC.
• Updated calls in createEpInfo and Delete to pass the appropriate NICType.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
network/manager.go	Added nicType parameter to GetEndpointID and added branching for DelegatedVMNIC.
cni/network/network.go	Modified calls to GetEndpointID to pass NICType in endpoint creation and deletion.

Comments suppressed due to low confidence (3)

network/manager.go:118

• Changing the GetEndpointID signature is a breaking API change. Ensure all implementations of NetworkManager are updated (including mocks/stubs) and consider bumping the major version or updating documentation accordingly.

	GetEndpointID(containerID, ifName string, nicType cns.NICType) string

network/manager.go:734

• The doc comment should be updated to mention the new nicType parameter and describe its effect on the returned endpoint ID.

// GetEndpointID returns a unique endpoint ID based on the CNI mode.

cni/network/network.go:715

• No unit tests were added to cover the new behavior when NICType is DelegatedVMNIC. Add tests to verify both stateless and non-stateless modes with different NIC types.

		endpointID = plugin.nm.GetEndpointID(opt.args.ContainerID, ifName, opt.ifInfo.NICType)

[Copilot]

[nitpick] Consider using fmt.Sprintf("%s-%s", containerID, ifName) or defining a constant delimiter to improve readability and consistency.

[github-actions]

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

[github-actions]

Pull request closed due to inactivity.