fix: handle SSL certificate verification failure in curl install script (closes #28044)#33711
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
|
Hi @botbikamordehai2-sketch, |
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
jsntcy,
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @botbikamordehai2-sketch! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Collaborator
|
handle SSL certificate verification failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
curl_install_pypi/install.pyscript usesurlopenfromurllib.requestwithout SSL context customization. On corporate networks with self-signed certificates, this causesSSLCertVerificationErrorand prevents installation of Bicep (and the CLI itself if using the curl install method).Fix
Add
ssl._create_unverified_contextas the default HTTPS context before any HTTPS requests are made. This matches the pattern used in other parts of the Azure CLI codebase (e.g.,azure-cli-core/azure/cli/core/_profile.py) and allows users behind corporate proxies with custom certificates to install the CLI.Closes #28044